OK please do this:
tmux -vvvvLtest -f/dev/null new
Then reproduce the problem as simply as possible, then exit tmux and
send me the tmux-*.log files from the current directory.
On Fri, May 12, 2017 at 03:11:57PM +0300, ?????????????? wrote:
> yes, i tried it on latest master
> On Fri, May 12, 2017 at 12:47 AM, Nicholas Marriott
> <[email protected]> wrote:
>
> Do you have 989cdca95fa2e1a4dc3849020838328aded09164?
>
> On Thu, May 11, 2017 at 04:08:43PM +0300, ?????????????? wrote:
> >A A Thank you, this fixes it, but only partly (on last master):
> everything is
> >A A good, but if switch to another window and back again or select
> something
> >A A with my mouse -- problem reappears
> >A A On Thu, May 11, 2017 at 9:44 AM, Nicholas Marriott
> >A A <[email protected]> wrote:
> >
> >A A A Try this instead please:
> >
> >A A A Index: input.c
> >A A A
> ===================================================================
> >A A A RCS file: /cvs/src/usr.bin/tmux/input.c,v
> >A A A retrieving revision 1.119
> >A A A diff -u -p -r1.119 input.c
> >A A A --- input.cAA AA A 22 Apr 2017 08:33:28 -0000AA AA AA
> 1.119
> >A A A +++ input.cAA AA A 11 May 2017 06:43:44 -0000
> >A A A @@ -1308,7 +1308,8 @@ input_csi_dispatch(struct input_ctx *ict
> >A A A AA AA AA AA AA AA AA AA }
> >A A A AA AA AA AA AA AA AA AA break;
> >A A A AA AA AA AA case INPUT_CSI_ECH:
> >A A A -AA AA AA AA AA AA AA A
> screen_write_clearcharacter(sctx,
> >A A A input_get(ictx, 0, 1, 1));
> >A A A +AA AA AA AA AA AA AA A
> screen_write_clearcharacter(sctx,
> >A A A input_get(ictx, 0, 1, 1),
> >A A A +AA AA AA AA AA AA AA AA AA A ictx->cell.cell.bg);
> >A A A AA AA AA AA AA AA AA AA break;
> >A A A AA AA AA AA case INPUT_CSI_DCH:
> >A A A AA AA AA AA AA AA AA AA
> screen_write_deletecharacter(sctx,
> >A A A input_get(ictx, 0, 1, 1),
> >A A A Index: screen-write.c
> >A A A
> ===================================================================
> >A A A RCS file: /cvs/src/usr.bin/tmux/screen-write.c,v
> >A A A retrieving revision 1.119
> >A A A diff -u -p -r1.119 screen-write.c
> >A A A --- screen-write.cAA AA AA 29 Apr 2017 21:27:46 -0000AA
> AA AA 1.119
> >A A A +++ screen-write.cAA AA AA 11 May 2017 06:43:44 -0000
> >A A A @@ -606,7 +606,7 @@ screen_write_deletecharacter(struct scre
> >
> >A A A A /* Clear nx characters. */
> >A A A A void
> >A A A -screen_write_clearcharacter(struct screen_write_ctx *ctx,
> u_int nx)
> >A A A +screen_write_clearcharacter(struct screen_write_ctx *ctx,
> u_int nx,
> >A A A u_int bg)
> >A A A A {
> >A A A AA AA AA AA struct screenAA A *s = ctx->s;
> >A A A AA AA AA AA struct tty_ctxAA A ttyctx;
> >A A A @@ -623,6 +623,7 @@ screen_write_clearcharacter(struct scree
> >A A A AA AA AA AA AA AA AA AA return;
> >
> >A A A AA AA AA AA screen_write_initctx(ctx, &ttyctx);
> >A A A +AA AA AA A ttyctx.bg = bg;
> >
> >A A A AA AA AA AA grid_view_clear(s->grid, s->cx, s->cy, nx, 1,
> 8);
> >
> >A A A Index: tmux.h
> >A A A
> ===================================================================
> >A A A RCS file: /cvs/src/usr.bin/tmux/tmux.h,v
> >A A A retrieving revision 1.763
> >A A A diff -u -p -r1.763 tmux.h
> >A A A --- tmux.hAA AA AA 10 May 2017 16:48:36 -0000AA AA AA
> 1.763
> >A A A +++ tmux.hAA AA AA 11 May 2017 06:43:45 -0000
> >A A A @@ -1996,7 +1996,7 @@ voidAA AA AA A
> screen_write_cursorleft(struct scr
> >A A A A voidAA AA screen_write_alignmenttest(struct
> screen_write_ctx *);
> >A A A A voidAA AA screen_write_insertcharacter(struct
> screen_write_ctx *,
> >A A A u_int, u_int);
> >A A A A voidAA AA screen_write_deletecharacter(struct
> screen_write_ctx *,
> >A A A u_int, u_int);
> >A A A -voidAA AA screen_write_clearcharacter(struct
> screen_write_ctx *,
> >A A A u_int);
> >A A A +voidAA AA screen_write_clearcharacter(struct
> screen_write_ctx *, u_int,
> >A A A u_int);
> >A A A A voidAA AA screen_write_insertline(struct screen_write_ctx
> *, u_int,
> >A A A u_int);
> >A A A A voidAA AA screen_write_deleteline(struct screen_write_ctx
> *, u_int,
> >A A A u_int);
> >A A A A voidAA AA screen_write_clearline(struct screen_write_ctx
> *, u_int);
> >A A A Index: tty.c
> >A A A
> ===================================================================
> >A A A RCS file: /cvs/src/usr.bin/tmux/tty.c,v
> >A A A retrieving revision 1.272
> >A A A diff -u -p -r1.272 tty.c
> >A A A --- tty.cAA AA AA A 10 May 2017 18:40:13 -0000AA AA AA
> 1.272
> >A A A +++ tty.cAA AA AA A 11 May 2017 06:43:45 -0000
> >A A A @@ -1019,7 +1019,7 @@ tty_cmd_deletecharacter(struct tty *tty,
> >A A A A void
> >A A A A tty_cmd_clearcharacter(struct tty *tty, const struct tty_ctx
> *ctx)
> >A A A A {
> >A A A -AA AA AA A tty_attributes(tty, &grid_default_cell,
> ctx->wp);
> >A A A +AA AA AA A tty_default_attributes(tty, ctx->wp, ctx->bg);
> >A A A AA AA AA AA tty_cursor_pane(tty, ctx, ctx->ocx, ctx->ocy);
> >
> >A A A On Thu, May 11, 2017 at 08:33:20AM +0300, ??????????????
> wrote:
> >A A A >AA AA No, this didn't help. Now background for spaces is
> "random" (it
> >A A A is
> >A A A >AA AA different every other tmux launch)
> >A A A >AA AA I can submit issue on github with logs and all stuff
> if this is
> >A A A indeed a
> >A A A >AA AA bug (I haven't done it yet because I found in "Note
> that TERM
> >A A A inside tmux
> >A A A >AA AA must be a variant of screen or tmux" in CONTRIBUTING
> file and
> >A A A with
> >A A A >AA AA TERM=screen-256color the problem doesnt exist)
> >A A A >AA AA On Thu, May 11, 2017 at 12:34 AM, Nicholas Marriott
> >A A A >AA AA <[email protected]> wrote:
> >A A A >
> >A A A >AA AA AA I don't know what you are looking at that has
> tty_reset, but
> >A A A the problem
> >A A A >AA AA AA is most likely that ECH should take account of
> BCE, so it
> >A A A should call
> >A A A >AA AA AA tty_default_atttributes instead of
> tty_attributes. Please try
> >A A A this:
> >A A A >
> >A A A >AA AA AA Index: tty.c
> >A A A >AA AA A
> >A A A
> ===================================================================
> >A A A >AA AA AA RCS file: /cvs/src/usr.bin/tmux/tty.c,v
> >A A A >AA AA AA retrieving revision 1.272
> >A A A >AA AA AA diff -u -p -r1.272 tty.c
> >A A A >AA AA AA --- tty.cAAA AAA AAA A 10 May 2017 18:40:13
> -0000AAA AAA AA
> >A A A 1.272
> >A A A >AA AA AA +++ tty.cAAA AAA AAA A 10 May 2017 21:34:36
> -0000
> >A A A >AA AA AA @@ -1019,7 +1019,9 @@
> tty_cmd_deletecharacter(struct tty *tty,
> >A A A >AA AA AA A void
> >A A A >AA AA AA A tty_cmd_clearcharacter(struct tty *tty, const
> struct tty_ctx
> >A A A *ctx)
> >A A A >AA AA AA A {
> >A A A >AA AA AA -AAA AAA AAA A tty_attributes(tty,
> &grid_default_cell,
> >A A A ctx->wp);
> >A A A >AA AA AA +AAA AAA AAA A struct window_paneAAA AAA
> AAA *wp = ctx->wp;
> >A A A >AA AA AA +
> >A A A >AA AA AA +AAA AAA AAA A tty_default_attributes(tty, wp,
> ctx->bg);
> >A A A >
> >A A A >AA AA AA AAA AAA AAA AAA tty_cursor_pane(tty, ctx,
> ctx->ocx, ctx->ocy);
> >A A A >
> >A A A >AA AA AA On Wed, May 10, 2017 at 10:09:29PM +0300,
> ??????????????
> >A A A wrote:
> >A A A >AA AA AA >AAA AAA Hello.
> >A A A >AA AA AA >AAA AAA I have unexpected and annoying (a bit)
> behaviour
> >A A A >AA AA AA >AAA AAA withA tmux,A visA
> (https://github.com/martanne/vis)A
> >A A A and 256
> >A A A >AA AA AA color
> >A A A >AA AA AA >AAA AAA terminals supporting 'ech' terminfo
> entry
> >A A A (st-256color (true
> >A A A >AA AA AA color also),
> >A A A >AA AA AA >AAA AAA xterm-256color).
> >A A A >AA AA AA >AAA AAA visA has status line (just like tmux).
> >A A A >AA AA AA >AAA AAA But when i use st-256color or
> xterm-256color as TERM,
> >A A A it prints
> >A A A >AA AA AA status
> >A A A >AA AA AA >AAA AAA line with spaces on black background
> while other text
> >A A A is on gray
> >A A A >AA AA AA >AAA AAA (http://i.imgur.com/DA4VdN5.png).
> >A A A >AA AA AA >AAA AAA - line looks good when I use those
> terminals without
> >A A A tmux
> >A A A >AA AA AA >AAA AAA - line looks good if i manually remove
> 'ech' in
> >A A A terminfo of those
> >A A A >AA AA AA >AAA AAA terminals (or use screen-256color)
> (setting 'ech@' in
> >A A A >AA AA AA terminal-overrides
> >A A A >AA AA AA >AAA AAA doesn't help)
> >A A A >AA AA AA >AAA AAA Investigations (btw debugging tmux is
> very satisfying
> >A A A :D) lead me
> >A A A >AA AA AA to
> >A A A >AA AA AA >AAA AAA conclusion that this is because there
> is a tty_reset
> >A A A right before
> >A A A >AA AA AA 'ech'
> >A A A >AA AA AA >AAA AAA command.
> >A A A >AA AA AA >AAA AAA (which is there since this the
> beginning of
> >A A A >AA AA AA >AAA AAA implementationA
> >A A A >AA AA A
> >A A A
>
> https://github.com/tmux/tmux/commit/44f8e1caffce2e887682c3314ee22becc09e1d3cA
> >A A A >AA AA AA and
> >A A A >AA AA AA >AAA AAA is inside tty_attributes in master)
> >A A A >AA AA AA >AAA AAA When I comment call to tty_attributes
> inside
> >A A A >AA AA AA tty_cmd_clearcharacter (or
> >A A A >AA AA AA >AAA AAA use &tty->last_cell instead of
> grid_default_cell as
> >A A A 2nd argument)
> >A A A >AA AA AA >AAA AAA everything becomes fine too (didn't
> fully understand
> >A A A wtf i was
> >A A A >AA AA AA doing
> >A A A >AA AA AA >AAA AAA actually)
> >A A A >AA AA AA >AAA AAA From man terminfo:
> >A A A >AA AA AA >AAA AAA A A command to erase n characters
> (equivalent to
> >A A A outputting n
> >A A A >AA AA AA blanks
> >A A A >AA AA AA >AAA AAA without moving the cursor) can be
> given asA echA with
> >A A A one
> >A A A >AA AA AA parameter.
> >A A A >AA AA AA >AAA AAA So I am wondering if this is a bug in
> tmux and if
> >A A A not, could
> >A A A >AA AA AA someone
> >A A A >AA AA AA >AAA AAA clarify this for me: Why do we need
> tty_reset there?
> >A A A >AA AA AA >AAA AAA BR,
> >A A A >AA AA AA >AAA AAA Evgeniy Stratonikov
> >A A A >AA AA AA >
> >A A A >AA AA AA >AAA AAA --
> >A A A >AA AA AA >AAA AAA You received this message because you
> are subscribed
> >A A A to the
> >A A A >AA AA AA Google Groups
> >A A A >AA AA AA >AAA AAA "tmux-users" group.
> >A A A >AA AA AA >AAA AAA To unsubscribe from this group and
> stop receiving
> >A A A emails from it,
> >A A A >AA AA AA send an
> >A A A >AA AA AA >AAA AAA email to
> [email protected].
> >A A A >AA AA AA >AAA AAA To post to this group, send email to
> >A A A [email protected].
> >A A A >AA AA AA >AAA AAA For more options, visit
> >A A A https://groups.google.com/d/optout.
> >A A A >
> >A A A >AA AA --
> >A A A >AA AA You received this message because you are subscribed
> to the
> >A A A Google Groups
> >A A A >AA AA "tmux-users" group.
> >A A A >AA AA To unsubscribe from this group and stop receiving
> emails from it,
> >A A A send an
> >A A A >AA AA email to [email protected].
> >A A A >AA AA To post to this group, send email to
> [email protected].
> >A A A >AA AA For more options, visit
> https://groups.google.com/d/optout.
> >
> >A A --
> >A A You received this message because you are subscribed to the
> Google Groups
> >A A "tmux-users" group.
> >A A To unsubscribe from this group and stop receiving emails from it,
> send an
> >A A email to [email protected].
> >A A To post to this group, send email to [email protected].
> >A A For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups
"tmux-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
