OK great, let me know if you see any problems. The way alerts work is complicated and we usually do manage to break some way to use it with each change but hopefully this will be different...
Thanks On Thu, Jul 27, 2017 at 01:29:06AM +0200, Yvain Thonnart wrote: > Hi Thomas, Nicholas, > > I've run some tests against different revisions of the tree. > In a nutshell, the logs do not seem to show much more timer reset between > different versions. It's not filling the logs at lightspeeda*| > > If actually what Thomas meant was, activity keeps being signalled with > either visual bell, urgency hint (or audible bell - yet I didn't do it, I > care for my ears), it is filtered for non-active window: > the alert is notified only once, before and after Nicholas' last patch. > > It is indeed recurring for the current window, which I find is a good > behaviour - the behaviour I want, at least: > - window is not visible in the WM > -> urgency highlights it (or pops it up) on activity > -> I briefly give it a look to check if all is OK and switch to another > window I'm actively working on, with no interaction at all with tmux, only > the WM. > -> and again and again depending on my program output > Of course, it can be used dangerously. > I've tried with unbuffered IO for 1M characters (sleep 10; ./tmux -vvvv > new-session sh -c "perl -e '"'$|++;print "." for (0..1000000)'"'"). > It generates 2865 messages 'Activity in current window' in 1.25s, i.e. > about 4 per millisecond. > But if used as a hint, my window gets highlighted, and that's all. > > I'd say, on my side, that I'm more than fine with current master. > But maybe I'm missing the particular configuration you wanted to target, > Thomas. > > Again, thank you both for your work on tmux. > > Best regards, > > Yvain > About the detailed log sizes, just to give you some data: > ------------------------------------- > From the initial master branch before Nicholas and I worked on this issue > (e725b96a): > > set -g visual-activity on > set -g monitor-activity on > > A A A ./tmux -vvvv new-session sh -c 'for i in $(seq 1 20) ; do echo > hello; sleep 1; done' > A A A => A A -rw-rw-r-- 1 yvain yvainA 97303 2017-07-26 23:26 > tmux-server-mon-act-e725b96a-current.log > (this was sort of the one that pushed me to propose a patch. -> no > activity in current window. > A A A ./tmux new-session -d sh -c 'for i in $(seq 1 20) ; do echo hello; > sleep 1; done' ; ./tmux neww ; ./tmux attach > A A A =>A A A -rw-rw-r-- 1 yvain yvain 226814 2017-07-26 23:26 > tmux-server-mon-act-e725b96a-other.log > (this is the original activity monitoring in a hidden window) > > We have an overhead of initializing 2 sessions, plus the exit from the > second window. > Yet this is roughly the baseline for the following test. > > ------------------------------------- > From the penultimate commit from Nicholas (before reseting in all cases): > 76887b1d > and his last commit (after resetting in al cases): 58744de3 > When monitoring for activity (as in the previous case) > set -g activity-action any > set -g visual-activity on > set -g monitor-activity on > > before: > A A A ./tmux -vvvv new-session sh -c 'for i in $(seq 1 20) ; do echo > hello; sleep 1; done' > A A A =>A A A -rw-rw-r-- 1 yvain yvain 259175 2017-07-26 23:02 > tmux-server-mon-act-76887b1d.log > after: > A A A ./tmux -vvvv new-session sh -c 'for i in $(seq 1 20) ; do echo > hello; sleep 1; done' > A A A =>A A A -rw-rw-r-- 1 yvain yvain 259743 2017-07-26 23:02 > tmux-server-mon-act-58744de3.log > > Only 23 lines more: > +once at session creation: event_del: event has no event_base set. > +22 times: @0 alerts timer reset 0 > > 21 times in both cases: message Activity in current window > > ------------------------------------- > And when monitoring for silence and activity (the one that we found an > issue requiring patch 58744de3) > set -g activity-action other > set -g silence-action current > set -g visual-activity on > set -g visual-silence on > set -g monitor-silence 10 > set -g monitor-activity on > > before: > A A A ./tmux -vvvv new-session sh -c 'for i in $(seq 1 20) ; do echo > hello; sleep 1; done' > A A A =>A A A -rw-rw-r-- 1 yvain yvainA 98725 2017-07-26 22:51 > tmux-server-mon-act-sil-76887b1d.log > after: > A A A ./tmux -vvvv new-session sh -c 'for i in $(seq 1 20) ; do echo > hello; sleep 1; done' > A A A =>A A A -rw-rw-r-- 1 yvain yvainA 98812 2017-07-26 22:51 > tmux-server-mon-act-sil-58744de3.log > > +22 times: @0 alerts timer reset 0 > > Strangely, the 76887b1d one reports Silence in current window only when > run interactively > (i.e. when the for loop is run from an existing window) > In that case, the logs become bigger, but with about the same minimal > difference + the silence log. -- You received this message because you are subscribed to the Google Groups "tmux-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
