Yeah normally I move the tag just before I make the tarball but in 2.7 I must have done it before I changed the version.
On Wed, 17 Oct 2018, 21:54 Cam Hutchison, <[email protected]> wrote: > Oh, the tags are moving. I just do a git pull and I guess it does not > update existing tags, so I have a tag from the rc release that is > tagged as 2.8. > > I just did a git pull --tags and it updated my 2.6 and 2.8 tag. For > some reason, 2.7 was not updated. Looking at the github repo, that tag > is on the wrong commit as configure.ac has 2.7-rc there. > > I'll remember to update the tags in future. > > Thanks. > On Thu, 18 Oct 2018 at 07:50, Nicholas Marriott > <[email protected]> wrote: > > > > > > Are you sure your 2.8 tag is up to date? It should point to > > 01918cb0170e07288d3aec624516e6470bf5b7fc. > > > > > > On Thu, Oct 18, 2018 at 07:46:59AM +1100, Cam Hutchison wrote: > > > Actually, I just pulled the git repo and checked out the "2.8" tag. > > > That still has 2.8-rc in configure.ac. > > > > > > Is this just an artifact of using git? I didn't bother checking the > > > tarball because I saw it was served by github and figured it must have > > > come from the tagged commit. > > > > > > I just checked the tarball, and as you suggest, it has 2.8 as the > version. > > > > > > There is a commit in the repo that changes the CHANGES file to change > > > master -> 2.8, but nothing for configure.ac. > > > > > > I always build from the git tag, and lately I have needed to change > > > configure.ac each time. > > > On Thu, 18 Oct 2018 at 07:37, Nicholas Marriott > > > <[email protected]> wrote: > > > > > > > > Hi > > > > > > > > Are you sure you have the release tarball and not an RC tarball? > > > > > > > > > > > > On Wed, 17 Oct 2018, 21:22 Cam Hutchison, <[email protected]> wrote: > > > >> > > > >> On Thu, 18 Oct 2018 at 05:44, Nicholas Marriott > > > >> <[email protected]> wrote: > > > >> > > > > >> > Hi all > > > >> > > > > >> > I have released tmux 2.8: > > > >> > > > > >> > > https://github.com/tmux/tmux/releases/download/2.8/tmux-2.8.tar.gz > > > >> > > > >> I have noticed that since tmux 2.6, the version has an "-rcX?" tag > > > >> appended to it. Prior versions had an unadorned version number. I > did > > > >> not notice anything in the CHANGES file in 2.6 about this. > > > >> > > > >> Is this intended? > -- You received this message because you are subscribed to the Google Groups "tmux-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
