On 28/10/2013 00:15, Thomas Adam wrote: > On Sun, Oct 27, 2013 at 11:37:02PM +0100, Marcel Partap wrote: >> Rename >> screen_redraw_cell_border1() => screen_redraw_get_border_rel() >> screen_redraw_cell_border() => screen_redraw_cell_is_border() >> screen_redraw_check_cell() => screen_redraw_get_cell_type() >> screen_redraw_check_active() => screen_redraw_check_active_pane_indicator() > > As Nicholas has mentioned, this does much more than just rename some > functions, and neither does this, nor any of the other three patches you've > sent through, indicate any rationale for this change.
To get back to this: the functions were renamed (and subsequently restructured) to not do multiple unrelated things and better align name with what they do. When doing this, of course I grepped the source for all invocations of these functions to be sure to not break anything. I totally should have documented this better, sorry. > IIRC from an earlier round, these patches were designed to somehow "better" > indicate which pane has the focus? If that's true, we still have the > split-pane colourisation thing which seems to do this, albeit perhaps not as > intuitively. Well yes, somehow better, and I still favor it, to the point where I propose it should be the new default. After having used both styles for several years now. So I'll try reapplying the patch series and put forward again. Best Regards, #marcel -- You received this message because you are subscribed to the Google Groups "tmux-users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/tmux-users/a79546ca-5bf5-92a1-9ddb-200424166fc5%40gmx.net. For more options, visit https://groups.google.com/d/optout.
