Also, for contrast, here is the effect of the same patch on 3.0-rc. Both 3.0-rc (printf patch) and master (compaction + printf patches) are reporting the same 36 number for the size of struct grid_cell.
$ pgrep tmux | xargs -r ps u
USER PID %CPU %MEM VSZ RSS TTY STAT START TIME COMMAND
sunny 11467 0.0 0.0 7120 3280 pts/1 S+ 14:13 0:00 tmux
sunny 11469 1.3 7.7 313312 309536 ? Rs 14:13 0:09 tmux
$ tmux display -p '#{history_bytes}'
68939,36
$ tmux lsp -aF '#{pane_id} #{history_bytes}'
%1 10414942,36
%2 11566347,36
%3 68939,36
%4 29299,36
%5 14790000,36
%6 19912,36
%7 19570538,36
%8 16828680,36
%9 45909,36
%10 708177,36
%11 1416667,36
%12 457673,36
%13 528808,36
%14 1296060,36
%15 9743781,36
%16 9868770,36
%17 7045780,36
%18 11011243,36
%19 835906,36
%20 22567043,36
%21 13197272,36
%22 15372503,36
%23 19222647,36
%24 12896611,36
%25 4660126,36
%26 11658149,36
%27 4434778,36
%28 11079426,36
%29 2222177,36
%30 124916,36
%31 302090,36
%32 194485,36
On Wed, 3 Jul 2019 14:12:57 -0700, Suraj N. Kurapati wrote:
> With both patches applied, here is the new VSZ and diagnostic output:
>
> $ pgrep tmux | xargs -r ps u
> USER PID %CPU %MEM VSZ RSS TTY STAT START TIME
> COMMAND sunny 2064 0.0 0.0 7124 3384 pts/1 S+ 14:07
> 0:00 tmux sunny 2066 22.6 26.1 1050128 1045272 ? Rs 14:07
> 0:11 tmux
>
> $ tmux display -p '#{history_bytes}'
> 113399862,36
>
> $ tmux lsp -aF '#{pane_id} #{history_bytes}'
> %1 12352246,36
> %2 21097851,36
> %3 135677,36
> %4 126967,36
> %5 113399862,36
> %6 44104,36
> %7 37920818,36
> %8 104899188,36
> %9 272889,36
> %10 1544601,36
> %11 8835943,36
> %12 2828741,36
> %13 3170380,36
> %14 1333320,36
> %15 21239769,36
> %16 13284234,36
> %17 48166564,36
> %18 86578267,36
> %19 875254,36
> %20 26066171,36
> %21 94160444,36
> %22 116190395,36
> %23 49716951,36
> %24 95909911,36
> %25 34273150,36
> %26 34015805,36
> %27 12252574,36
> %28 13825470,36
> %29 16606409,36
> %30 983120,36
> %31 1129190,36
> %32 1468021,36
>
> On Wed, 3 Jul 2019 20:12:45 +0100, Nicholas Marriott wrote:
> > Apply this please and show me the output of
> >
> > tmux display -p '#{history_bytes}'
> >
> > In any pane.
> >
> >
> > Index: format.c
> > ===================================================================
> > RCS file: /cvs/src/usr.bin/tmux/format.c,v
> > retrieving revision 1.207
> > diff -u -p -r1.207 format.c
> > --- format.c 24 Jun 2019 10:04:29 -0000 1.207
> > +++ format.c 3 Jul 2019 19:12:18 -0000
> > @@ -612,7 +612,7 @@ format_cb_history_bytes(struct format_tr
> > }
> > size += gd->hsize * sizeof *gl;
> >
> > - xasprintf(&fe->value, "%llu", size);
> > + xasprintf(&fe->value, "%llu,%zu", size, sizeof (struct
> > grid_cell)); }
> >
> > /* Callback for pane_tabs. */
> >
--
You received this message because you are subscribed to the Google Groups
"tmux-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send an email to [email protected].
To view this discussion on the web, visit
https://groups.google.com/d/msgid/tmux-users/20190703142759.137002dc%40ratham.attlocal.net.
For more options, visit https://groups.google.com/d/optout.
pgpZtS5vOkmPW.pgp
Description: OpenPGP digital signature
