On Mon, Dec 06, 2010 at 09:50:23PM +0000, Thomas Adam wrote:
> Hi --
> 
> On Mon, Dec 06, 2010 at 09:39:33PM +0000, Nicholas Marriott wrote:
> > I like it and looks fine apart from a couple of man page nits: 
> 
> OK.  I am sure I can iron those out.  ;)
> 
> > - Each new sentence gets a new line (reduces diff size for minor
> > fixes).
> 
> I don't understand what you mean here.  Can you be more specific?  Maybe
> speak louder and slower?  ;)

+Set the timeout (in seconds) after which if no output happens in the given
+window, silence is flagged.  See the
+.Ic monitor-silence
+option.
+.Pp

Becomes:

+Set the timeout (in seconds) after which if no output happens in the given
+window, silence is flagged.
+See the
+.Ic monitor-silence
+option.
+.Pp

Basically newline after every period.

It means that you don't end up with a gigantic diff reflowing entire
paragraphs if someone changes one word in a sentence.

> 
> > - We document what * and + etc mean (look for "Denotes") so you need to
> > add ~.
> 
> Ah crap.  Thanks.  Will fix once I understand your point from the above.
> 
> > It's dependent on another event waking us up, but that's fine because
> > the second timer will make sure it is checked at least once a
> > second... it's a pity everything can't be event-driven but that's the
> > way it is ATM.
> 
> Yeah -- don't forget also (promises, promises) that I've got a stale patch
> to move alerts to be per window, and not per winlink -- I'll resurrect that
> in due course, assuming the silence stuff gets pushed out first of all.
> Which is what I am hoping for.  ;)

Cool.

Fix those and this can go in now unless it doesn't work when I actually
test it.

> As an an aside to this, Nicholas, would you consider a patch to centralise
> flag definitions (either as an enum or a bunch of #defines)?  Only, there's
> far too many places where the literal char of the flag is hard-coded where
> it's needed for display -- if that makes sense?

That would be cool, I was thinking just a function somewhere to convert
them to a displayable character, probably in status.c.

> 
> Kindly,
> 
> -- Thomas Adam
> 
> 
> "Deep in my heart I wish I was wrong.  But deep in my heart I know I am
> not." -- Morrissey ("Girl Least Likely To" -- off of Viva Hate.)

------------------------------------------------------------------------------
What happens now with your Lotus Notes apps - do you make another costly 
upgrade, or settle for being marooned without product support? Time to move
off Lotus Notes and onto the cloud with Force.com, apps are easier to build,
use, and manage than apps on traditional platforms. Sign up for the Lotus 
Notes Migration Kit to learn more. http://p.sf.net/sfu/salesforce-d2d
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to