Yep this is wrong, doh, they should be the other way round. Fixed,
thanks.
On Wed, Mar 09, 2011 at 12:58:48AM +0900, Yusuke ENDOH wrote:
> Hello,
>
> This is an excerpt of tty_redraw_region in tty.c:
>
>
> 451 /*
> 452 * If region is >= 50% of the screen, just schedule a
> window redraw. In
> 453 * most cases, this is likely to be followed by some more
> scrolling -
> 454 * without this, the entire pane ends up being redrawn
> many times which
> 455 * can be much more data.
> 456 */
> 457 if (ctx->orupper - ctx->orlower >= screen_size_y(s) / 2) {
> 458 wp->flags |= PANE_REDRAW;
> 459 return;
> 460 }
>
>
> I suspect that "ctx->orupper - ctx->orlower" causes underflow
> because ctx->orupper is less or equal than orlower and their
> types are unsigned. This mean this condition is always true
> unless they are equal.
>
> I could be wrong, but is this condition right?
>
> Thanks,
>
> --
> Yusuke Endoh <m...@tsg.ne.jp>
>
> ------------------------------------------------------------------------------
> What You Don't Know About Data Connectivity CAN Hurt You
> This paper provides an overview of data connectivity, details
> its effect on application quality, and explores various alternative
> solutions. http://p.sf.net/sfu/progress-d2d
> _______________________________________________
> tmux-users mailing list
> tmux-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/tmux-users
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users
