Hi I got it now. Thanks.
This mostly looks fine aside from style nits which will be easy to sort out, although I'll wait to see the diff to see what impact it has outside control.c. You will need to add your copyright line to the top of control.c and the other new files. For new commands, if they aren't useful outside control mode I would consider renaming them to add eg a control- prefix, or hiding them all under an umbrella control-mode-command or something. I would probably only document -C in the man page for the moment and any of the new commands which would be useful outside control clients. I'll have to test it at some point too. I suppose it won't do me too much harm to use OS X for a bit... Are there any parts we can break off and commit separately to make the diff smaller? For example the layout and join pane changes. On Fri, Jan 20, 2012 at 02:54:00PM -0800, George Nachman wrote: > Hi Nicholas, > > I didn't create that tree correctly, so I started a new one here: > https://github.com/gnachman/tmux2/tree/command_mode > > Make sure you look in the command_mode branch that I linked to: master > is where I pull updates from svn to keep things up to date and doesn't > include my changes. > > I'm going to publish the iTerm2 build that includes the integration > out on auto-update this weekend, which will get a larger audience of > testers. I expect that within a couple weeks I'll know about any > remaining serious bugs in my changes to tmux. > > I was holding off sending you an "official" patch until I was 100% > confident that it was free of design-changing bugs. I feel pretty good > about it, though, so if you want to start having a look, it would be > great. > > One thing I haven't done is to write any documentation. How much > detail do you think should be in the man page? Should I start a second > man page for control mode? > > The magic sequence of git commands to grab the code and diff my > changes vs mainline is this: > > git clone g...@github.com:gnachman/tmux2.git > cd tmux2 > git checkout command_mode > git pull origin command_mode > git diff origin/master > > Cheers, > G > > On Fri, Jan 20, 2012 at 12:19 PM, Nicholas Marriott > <nicholas.marri...@gmail.com> wrote: > > Where is the latest code? Is this it https://github.com/gnachman/tmux.git? > > > > Cheers > > > > > > On Tue, Dec 20, 2011 at 10:52:23PM -0800, George Nachman wrote: > >> If you use a Mac, you might be interested to know that a new test > >> build of iTerm2 includes tmux integration. By running tmux with a new > >> argument, tmux windows are rendered as native windows or tabs. There's > >> no more need for a prefix key. Interacting with windows and split > >> panes becomes easier, and you get access to a host of terminal > >> features that were previously unavailable or limited because of the > >> opacity of multiplexed terminals. > >> > >> You can download iTerm2 here: > >> http://code.google.com/p/iterm2/downloads/detail?name=iTerm2-1_0_0_20111219.zip > >> And you can get the source for my modified tmux here: > >> http://code.google.com/p/iterm2/downloads/detail?name=tmux-for-iTerm2-20111219.tar.gz > >> > >> More info on the integration can be found here: > >> http://code.google.com/p/iterm2/wiki/TmuxIntegration > >> > >> I'll submit a patch a few weeks into the new year so there's time to > >> find any fix any issues that come up. Many thanks for Nicholas for his > >> help so far! > >> > >> ------------------------------------------------------------------------------ > >> Write once. Port to many. > >> Get the SDK and tools to simplify cross-platform app development. Create > >> new or port existing apps to sell to consumers worldwide. Explore the > >> Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join > >> http://p.sf.net/sfu/intel-appdev > >> _______________________________________________ > >> tmux-users mailing list > >> tmux-users@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/tmux-users ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
