Ok let's lose the option and make it the default and that means we don't have to have resizep -F and that means no man page changes too.
I think I would try to put the call to grid_reflow into screen_resize but it will need an extra argument because we still won't want to do it in alternate screen, for the calls in window-copy.c etc. Richard, can you do these changes? If not I will try to do them tomorrow. Thanks On Thu, Jan 31, 2013 at 11:42:58AM +0000, Thomas Adam wrote: > Hi, > > On Thu, Jan 31, 2013 at 11:23:01AM +0000, Nicholas Marriott wrote: > > Hi > > > > Here is a tweaked version with some trivial style nitpicking and one > > change to not reflow when the application has issued smcup (alternate > > screen). > > > > I'm a bit torn about the need for an option - I'm not a huge fan of this > > behaviour but I don't think I actually care enough to need an option to > > turn it off. Thomas, what do you think? > > I think this is one of those options where people will largely expect > resizing a pane (and hence reflowing text) to Do The Right Thing (tm) so I'm > erring on the side of saying let's just make it the default and if people > _really_ do complain enough we can an option in to toggle it on/off. But to > be honest, given that this feature has been requested more than once, just > adding it in probably will appease most people. :) > > > The only other issue I have now is that notify_window_layout_changed is > > not really the right place for a call to window_reflow. Why not in > > window_pane_resize and window_pane_alternate_off, or even in > > screen_resize (with a extra flag argument for when it isn't wanted)? > > This was something I had thought about too. Layouts end up calling > layout_fix_panes() after having been mangled about which ends up calling > window_pane_resize() which then calls screen_resize(). So I think the check > should go in either of those two. > > -- Thomas Adam ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users
