Hmm sure. This fixed an actual bug so we shouldn't just revert.
So unless you know how to fix the previous code for old OS X version, we
may just disable automatic rename.
Can you try this? Untested of course. There is probably a less stupid
way to check the OS X version, if you know it let me know.
diff --git a/osdep-darwin.c b/osdep-darwin.c
index 23de9d5..9ec2496 100644
--- a/osdep-darwin.c
+++ b/osdep-darwin.c
@@ -18,6 +18,7 @@
#include <sys/types.h>
+#include <Availability.h>
#include <event.h>
#include <libproc.h>
#include <stdlib.h>
@@ -33,6 +34,7 @@ struct event_base *osdep_event_init(void);
char *
osdep_get_name(int fd, unused char *tty)
{
+#ifdef __MAC_10_7
struct proc_bsdshortinfo bsdinfo;
pid_t pgrp;
int ret;
@@ -44,6 +46,7 @@ osdep_get_name(int fd, unused char *tty)
&bsdinfo, sizeof bsdinfo);
if (ret == sizeof bsdinfo && *bsdinfo.pbsi_comm != '\0')
return (strdup(bsdinfo.pbsi_comm));
+#endif
return (NULL);
}
On Wed, Mar 27, 2013 at 03:12:04PM -0500, Jared Scheel wrote:
> This commit results in a failure to compile on 10.8.6:
>
> [1]http://sourceforge.net/p/tmux/tmux-code/ci/7360ff4496bfd159ac5935a18de675f067c375db/
> Error:
> osdep-darwin.c: In function *osdep_get_name*:
> osdep-darwin.c:36: error: storage size of *bsdinfo* isn*t known
> osdep-darwin.c:43: error: *PROC_PIDT_SHORTBSDINFO* undeclared (first use
> in this function)
> osdep-darwin.c:43: error: (Each undeclared identifier is reported only
> once
> osdep-darwin.c:43: error: for each function it appears in.)
> osdep-darwin.c:36: warning: unused variable *bsdinfo*
> make: *** [osdep-darwin.o] Error 1
> -Jared
>
> References
>
> Visible links
> 1.
> http://sourceforge.net/p/tmux/tmux-code/ci/7360ff4496bfd159ac5935a18de675f067c375db/
> ------------------------------------------------------------------------------
> Own the Future-Intel® Level Up Game Demo Contest 2013
> Rise to greatness in Intel's independent game demo contest.
> Compete for recognition, cash, and the chance to get your game
> on Steam. $5K grand prize plus 10 genre and skill prizes.
> Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
> _______________________________________________
> tmux-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/tmux-users
------------------------------------------------------------------------------
Own the Future-Intel® Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest.
Compete for recognition, cash, and the chance to get your game
on Steam. $5K grand prize plus 10 genre and skill prizes.
Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d
_______________________________________________
tmux-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/tmux-users