If you have nothing constructive to offer then please keep quiet.
On Thu, Apr 25, 2013 at 05:58:56PM -0700, Jason Timrod wrote: > Hi > I tried using this patch and the code is horrible. > Can we not use this? This blows goats > Jason > > -------------------------------------------------------------------------- > > From: Nicholas Marriott <nicholas.marri...@gmail.com> > To: Thomas <tho...@xteddy.org> > Cc: tmux-users@lists.sourceforge.net > Sent: Thursday, April 25, 2013 10:55 PM > Subject: Re: [PATCH 1/1] Allow conditional formats to expand formats > Ok. I think you have the right idea about recursing through > format_expand you are just going to need to pull out the affected format > differently (ditch strchr and use a custom loop which counts {s and }s). > > On Thu, Apr 25, 2013 at 10:25:09PM +0100, Nicholas Marriott wrote: > > Hi > > > > > @@ -232,7 +235,7 @@ format_expand(struct format_tree *ft, const char > *fmt) > > > ch = (u_char) *fmt++; > > > switch (ch) { > > > case '{': > > > - ptr = strchr(fmt, '}'); > > > + ptr = strrchr(fmt, '}'); > > > > How does this not break multiple formats in the same string? > > > > For example if I expand "#{pane_id} #{pane_id}" won't it look for a > > format called "pane_id} #{pane_id"? > > > > > if (ptr == NULL) > > > break; > > > n = ptr - fmt; > > > ------------------------------------------------------------------------------ > Try New Relic Now & We'll Send You this Cool Shirt > New Relic is the only SaaS-based application performance monitoring > service > that delivers powerful full stack analytics. Optimize and monitor your > browser, app, & servers with just a few lines of code. Try New Relic > and get this awesome Nerd Life shirt! > [1]http://p.sf.net/sfu/newrelic_d2d_apr > _______________________________________________ > tmux-users mailing list > [2]tmux-users@lists.sourceforge.net > [3]https://lists.sourceforge.net/lists/listinfo/tmux-users > > References > > Visible links > 1. http://p.sf.net/sfu/newrelic_d2d_apr > 2. mailto:tmux-users@lists.sourceforge.net > 3. https://lists.sourceforge.net/lists/listinfo/tmux-users ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr _______________________________________________ tmux-users mailing list tmux-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tmux-users