It looks like there's a bug in the window_copy_scroll_up and down
functions where they don't correctly highlight what's been selected
for copying.

To see the problem with window_copy_scroll_up, do the following:

1.  Generate more than a screenful of text.
2.  Enter copy mode.
3.  Scroll up some so that you'll be able to scroll down later.
4.  Move your cursor to the 3rd line from the top of the screen.
5.  Begin your selection.
6.  Move your cursor to the bottom of the screen.
7.  Note that the first line of your selection is on line 3, and it is
highlighted.
8.  Scroll down 1 line.

Notice that the first line of your selection is now on line 2, but it
is no longer highlighted.  It's still part of the selection, as a
copy&paste will demonstrate.  The problem with the highlighting
appears to be that window_copy_scroll_up calls window_copy_write_line
on the first 2 lines of the screen, and this removes the highlighting.

A similar problem happens with window_copy_scroll_down.  Continuing
from the steps above:

9.  Scroll down 2 lines.  The first line of your selection is now 1
line above the top of the screen.
10.  Scroll the window content down 2 lines (ctrl-y in vi mode).


The first line of your selection is now back on the 2nd line and is
highlighted, but so is the line above it, which is not part of the
selection.

I've attached a patch which corrects the behavior of both functions.

Attachment: tmux-scroll.patch
Description: Binary data

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to