Hey Nick!

Sorry, but this is still broken. :(

You can reproduce it in bash, if you type "a b" then go to the beginning
press "c": you can see that the "b" has disappeared and all you can see
is "ca".

Here's a patch to fix this.

diff --git a/grid-view.c b/grid-view.c
index a34c5a0..defb86d 100644
--- a/grid-view.c
+++ b/grid-view.c
@@ -184,7 +184,10 @@ grid_view_insert_cells(struct grid *gd, u_int px, u_int 
py, u_int nx)
        px = grid_view_x(gd, px);
        py = grid_view_y(gd, py);
 
-       sx = grid_view_x(gd, gd->linedata[py].cellsize);
+       sx = gd->linedata[py].cellsize + nx;
+       if (gd->sx < sx)
+               sx = gd->sx;
+       sx = grid_view_x(gd, sx);
        if (sx < px + nx)
                sx = px + nx;
 
@@ -203,7 +206,10 @@ grid_view_delete_cells(struct grid *gd, u_int px, u_int 
py, u_int nx)
        px = grid_view_x(gd, px);
        py = grid_view_y(gd, py);
 
-       sx = grid_view_x(gd, gd->linedata[py].cellsize);
+       sx = gd->linedata[py].cellsize + nx;
+       if (gd->sx < sx)
+               sx = gd->sx;
+       sx = grid_view_x(gd, sx);
        if (sx < px + nx)
                sx = px + nx;
 

But I'm just complicating stuff and I'm not even sure this will cover
all cases based on my previous track record so it's fine if you just
revert my patches for these two functions. I'd need more time to rethink
my approach to fix the original bug in a nice way but I don't think I'll
be able to do that in the very near future.

Thanks!

-- 
Balazs

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
tmux-users mailing list
tmux-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tmux-users

Reply via email to