Hi Alex, On Monday 06 January 2014 15:02:46 Damian, Alexandru wrote: > I've pushed to master a new version with some reworked bits intended to > make it easier to develop table views without copying a lot of code. > > This version is also targeted at integration in origin/master, Paul, can > you please review it ?
Just ran this - the functionality is great, good job. I'd like to see the grid columns being defined more in the database rather than in templates/code, but I guess we can add that optimisation later. There are some minor issues with the code itself however: > bitbake: toaster: clone Simple UI as base for Advanced UI * Don't add bootstrap 3.0 only to remove it in the next commit * This does more than just a clone and rename of the simple UI; there is a significant amount of code being added as well. I think this commit should stick to the copy/rename. * I'm not too thrilled with the s-prefixed template naming. Wouldn't it be better to just put these in a separate directory? Failing that, the prefix should be something a little more obvious e.g. "simple_" > bitbake: toaster: advanced UI, implement searching and filtering This commit does a bunch of re-indenting mixed in with material changes; this makes it hard to see what has actually changed. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
