On 13/01/2014 14:17, "Ravi Chintakunta" <[email protected]> wrote:
>Hi David, > >> -----Original Message----- >> From: Reyna, David [mailto:[email protected]] >> Sent: Monday, January 13, 2014 1:02 AM >> To: Ravi Chintakunta; Lerner, Dave; 'Damian, Alexandru'; 'Barros Pena, >> Belen'; 'Zhang, Jessica'; Bansal, Atul >> Cc: '[email protected]' >> Subject: RE: git push to poky-contrib/ravi >> >> Hi Ravi, >> >> Here is my first pass review. >> >> 1) I observe for your "...5ee1" commit there is no "Signed-off-by". >> Your other two commits do have that field. >> >> $ git log >> ... >> commit 2848c7e9cdb37890c5f602dc5a8cebc5fad95ee1 >> Author: Ravi Chintakunta <[email protected]> >> Date: Thu Jan 9 22:08:09 2014 -0500 >> >> Django settings: Removed duplicate toastergui entry in >> INSTALLED_APPS >> >> [[ no "Signed-off-by" ]] >> ... >> > >Yeah, I missed it. I saw the commit message guidelines after committing >this. > > >> 2) It does not appear that you have the row context coloring based on >> the "outcome" value. I actually have that working in my new "recipe >> details" page (via my "outcome_highlight" helper method). We could >> share this implantation. >> > >Yes, still work in progress. > >> 3) It appears that "{% if not objects %}" is the same as "{% ifequal 0 >> objects.count %}". If so, I can simplify my code accordingly. >> > >They are not same. "{% if not objects %}" will work when objects is None >and when the size is zero. Just a quick comment on this one: as a general rule, we don't display values when they are none or 0. The reason is to show only meaningful information, because there is already a lot of it! So, for example, if you look at the Time table http://www.yoctoproject.org/toaster/build-time.html you'll see that when time is 0 (for example, for not executed tasks) the cells are empty. > > >> 4) I observe that you have not implemented the href for the log file, >> presumably waiting for resolution of the questions you raised. >> > >Yes. > > >Thanks, >Ravi _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
