Hi Alex, Paul, Belen I've pushed a commit to poky-contrib(ssh://[email protected]/poky-contrib) for review on style, correct pattern implementation (doing things in templates vs views and vice versa), all other newbie related issues.
TESTING ------- While I have tested each flow and item, I have not documented these tests and will do so after I fix the templates and code per your recommendations. Then, I will update the branch as necessary and send out another review request. To summarize the build set that I used for testing: * core-image-minimal qemuarm * core-image-sato qemux86 * core-image-base, core-image-minimal genericx86 UNIMPLEMENTED FEATURES ---------------------- The unimplemented features are documented in the commits. The latest round of discussions on RvsT dependencies is not yet impelmented. And if I don't get any further feedback, I will implement per Belen's latest comments. Dependency ordering will be discussed in another email. COMMITS ------- There are two commits, urls.py and 'everything else'. The two commits are summarized as follows: -------------- commit aa179a36be6b39f44204476299f51658a25c7bd3 Author: Dave Lerner <[email protected]> Date: Wed Jan 15 14:25:28 2014 -0600 Implementation of package detail views The commit includes changes to implement package detail views. The views divide into a) package detail and dependency views when not installed in any image b) package detail and link to more detail when selected from a build view c) package detail, dependency views, and reverse dependency views when selected from an image view The views are based on specifications found in attachments to https://bugzilla.yoctoproject.org/show_bug.cgi?id=4328 with (a), (b) specified in design-1.5.1-package-details and (c) specified in design-1.1.1-included-package-details. Not all of the features are implemented in this commit. The next section describes stubs or unimplemented features. 1 Variance in all views: 1.1 Filesize units are implemented using the django template built-in filesizeformat filter. This filter differs from the spec as follows: (MB, KB, B) are shown with the filter as (MB, KB, bytes) The filter does not strip trailing '.0' numbers. 1.2 In the Package information sidebar the following fields are not implemented or only partially implemented: License files (see bugzilla 5648) Layer (the url unconditionally points to layers.openembedded.org/layerindex/branch/master/layers/ 1.3 Lists that should show RDEPENDS also show TRDEPENDS types and lists that should show RRECOMMENDS also show TRRECOMENDS types. 1.4 Relationship strings are as encoded in the relationship defining python dictionary, not per capitalized and stripped of leading 'r'. 2 Variance to Package Detail views when not in image (or selected via builds page, that is 1.5.1 specification above) 2.1 Dependency tab interactivity is not implemented. 2.2 Sorting per dependency relation names in the spec is not implemented. 3 Variance to Package Detail views when package is in image 3.1 The title is all in H1 format, only the package should be <strong>. 3.2 The rootfs table cell file entry interactivity is not implemented. 3.3 Runtime dependency table cell interactivity is not implemented. 3.4 Reverse dependency table cell interactivity is not implemented. Signed-off-by: Dave Lerner <[email protected]> commit 405223e088c106a3a8dd1ac78af339131633632a Author: Dave Lerner <[email protected]> Date: Wed Jan 15 15:56:13 2014 -0600 Add urls for package detail views This commit adds urls for the package detail views described in the bugzilla attachments to https://bugzilla.yoctoproject.org/show_bug.cgi?id=4328 The implementation views and templates are in a subsequent commit. The change adds five detailed package views references. For a package included in a target: 1) view for the package detail with files added to the file system 2) view for the runtime dependencies of that package 3) view for the reverse runtime dependencies of that package For a package not included in any target of a build: 4) view for the package detail with files that would be added 5) view for the runtime dependencies of that package Signed-off-by: Dave Lerner <[email protected]> -------------- I'm looking forward to any and all comments. Thanks, Dave Lerner _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
