One whitespace after 'checked' in the comment, and the end-of-file newline, not needed, indeed :)
Alex On Thu, Feb 6, 2014 at 12:20 PM, Ravi Chintakunta < [email protected]> wrote: > Hi Alex, > > Which white space are you referring to? If it is the blank line at the > end of the file in projecttags.py, I intentionally added it. Is it not > required? > > Thanks, > Ravi > ________________________________________ > From: Damian, Alexandru [[email protected]] > Sent: Thursday, February 06, 2014 5:23 AM > To: Barros Pena, Belen > Cc: Ravi Chintakunta; [email protected] > Subject: Re: [Toaster] git push for base html, base table, custom tags, > fitler dialog and All Tasks feature to ravi/all-tasks-feature > > This works for me! > > Can you please fix the whitespace ? > > git log -n1 -p will show you in red where the offending spaces are. > > > Thanks, > Alex > > > On Thu, Feb 6, 2014 at 10:18 AM, Barros Pena, Belen < > [email protected]<mailto:[email protected]>> wrote: > On 06/02/2014 04:09, "Ravi Chintakunta" <[email protected] > <mailto:[email protected]>> > wrote: > > >Hi Belen, > > > >> Just realised something, though. I am not sure if this was working > >> like > >> this before, or if I only saw it now: none of the filters have a > >> selection > >> in place when you open them. > >> > >> Filters are radio button groups, so one of the options must always be > >> selected by default, since they represent mutually exclusive options. > >> In > >> the case of the tasks table, all filters should have the "All" option > >> selected by default, since the table loads showing all tasks. > >> > >> Any chance that could be fixed at some point? > >> > > > >I have fixed this and pushed to my new branch: ravi/task-details-feature > > > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=ravi/task > >-details-feature&id=f829deee75cd1a616a0dc1a2a53d0879af67a475 > > This is looking good. Thanks for the fix! > > Belén > > > > >Thanks, > >Ravi > > _______________________________________________ > toaster mailing list > [email protected]<mailto:[email protected]> > https://lists.yoctoproject.org/listinfo/toaster > > > > -- > Alex Damian > Yocto Project > SSG / OTC > -- Alex Damian Yocto Project SSG / OTC
_______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
