Hi Amit, This was just a trial review. We are waiting for your commit to be pushed so that we can properly merge with it, as per my request. In our Wednesday call.
David From: Amit Kumar Chaudhary [mailto:[email protected]] Sent: Thursday, March 06, 2014 03:12 AM To: Wymore, Farrell; BARROS PENA, BELEN Cc: [email protected] <[email protected]> Subject: Re: [Toaster] toaster: review request for build dash board page Hello Farrell, On 5 March 2014 at 11:54:26 pm, Wymore, Farrell ([email protected]<mailto:[email protected]>) wrote: Dear Belen, I have pushed my first request for the build dash board page. I have tested for multiple build targets and targets that are not images. I’ve applied Alex’s patch for the database changes and manually included Amit’s error and warning code. Thanks for the patch, and including my work. But could you please pick the whole patch with header and everything, rather than merging it manually, because by doing it manually the credits gets left behind, and I would really like them to go with the patch. I would be happy to help in anyway I can with the merging. Thanks, —amit fwymore/build-dashboard The exceptions for this review are: • Waiting for license manifest decision • Waiting for image file table population from Alex • Issue around cached packages installed list We plan to review these in tomorrow’s call. Thanks – Farrell _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
_______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
