Hi, I took in: *bitbake: toaster: fix package size 1st sort order *
Can you please rebase: *bitbake: toaster: format packages with size = -1 *on top of the latest master ? Thanks, Alex On Thu, Mar 20, 2014 at 11:53 AM, Barros Pena, Belen < [email protected]> wrote: > On 18/03/2014 22:39, "Lerner, Dave" <[email protected]> wrote: > > >Alex, Belen > >The commits in lerner/fixes-031714 are based and built on top of the > >commits of lerner/imageinfo. > > Both fixes work for me. Thanks! > > > >-dave > > > >> -----Original Message----- > >> From: Lerner, Dave > >> Sent: Tuesday, March 18, 2014 5:27 PM > >> To: Damian, Alexandru ([email protected]); Barros Pena, Belen > >> ([email protected]) > >> Cc: [email protected] > >> Subject: [review-request] [toaster] yocto bugs 5966, 5914 > >> > >> Branch: lerner/fixes-031714 > >> Bugs: 5966, 5914 > >> > >> Testing > >> ------- > >> html5 validator check: yes > >> ws-before-eol: yes > >> > >> 5966 was validated for qemux86 sato busybox packages as per defect and > >>also on the > >> package list that appears when clicking core-image-sato from the build > >>dash boards. > >> Entries for virtual package dependencies were verified manually in the > >>database. > >> > >> 5914 was verified by deleting cookies, then clicking on Size column and > >>observing that > >> the sort order was descending. > >> > >> > >> Comments > >> -------- > >> commit 8cc9470688a2e5a73bf180f5b9bd11aec7eae53a > >> Author: Dave Lerner <[email protected]> > >> Date: Tue Mar 18 15:37:36 2014 -0500 > >> > >> bitbake: toaster: format packages with size = -1 > >> > >> [YOCTO #5966] > >> > >> Packages that have a size of -1 are virtual packages with limited > >> information. Such packages should be suppressed from the package > >> list page for an image. On dependency and reverse dependency lists > >>of > >> package, such packages should appear in muted rows, without links, > >> and with help information. > >> > >> The formatting rules are encapsulated into projecttags filters when > >> possible to minimize tests on size==-1 in the templates. A > >>currently > >> unused parameter is included in the filter format_vpackage_namehelp > >>to > >> minimize future change to specific help text which may change to > >> conform to referencing both the target and dependent packages' > >>names. > >> > >> Testing the relevant pages with an HTML5 validator found a stray end > >> tag in package_detail_base which has been fixed in this commit. > >> > >> Signed-off-by: Dave Lerner <[email protected]> > >> > >> .../toastergui/templates/package_detail_base.html | 2 +- > >> .../templates/package_included_dependencies.html | 14 ++++++++++--- > >> .../package_included_reverse_dependencies.html | 6 +++++- > >> .../toaster/toastergui/templatetags/projecttags.py | 21 > >>+++++++++++++++++++- > >> bitbake/lib/toaster/toastergui/views.py | 2 +- > >> 5 files changed, 38 insertions(+), 7 deletions(-) > >> > >> commit 50cf52db3443ecb66deed32d3c6e1897e9218e86 > >> Author: Dave Lerner <[email protected]> > >> Date: Tue Mar 18 09:24:43 2014 -0500 > >> > >> bitbake: toaster: fix package size 1st sort order > >> > >> [YOCTO #5914] > >> > >> On the pages with tables listing packages with a size column, > >>change the > >> first click sort order on the size column so that packages are > >>sorted in > >> decreasing order instead of increasing order. It is more likely > >>that > >> the user sorts this page data by size because the user is > >>interested in > >> those packages consuming the most disk space. > >> > >> Signed-off-by: Dave Lerner <[email protected]> > >> > >> bitbake/lib/toaster/toastergui/views.py | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > > > > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
