Hi Belen and Alex, Alex wrote with regards to the Build Dashboard (4258) review request:
"isDashboardPage" seems to be targeting only the dashboard page; I'm not sure that cluttering base template files with page-specific code is a good idea, as it will lead to lots of very complicated code moving forward. I would suggest dropping this enhancement since it only affects whenever a link is enabled or not, the easy thing to do is just display the link at all times. If this is unacceptable, it is better to break the needed content into a block, and override this block in the dashboard-specific page. I have two requirements that affect the navigation box, the above dashboard page instance plus this requirement: 5916 "The current page should have its left navigation item highlighted" I suspect that you Belen would like to keep your design. To satisfy Alex, I can therefore implement both requirements using blocks, where each page would override its respective block with highlighting and/or hiding as appropriate. Do you two accept this proposal? Thanks, David -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
