Hi Belen, Alex, Here is the review request extension of the unbuilt aka 'virtual' package formatting applied to the page that shows a built, but not installed, list of dependent packages. Dave
Branch: lerner/bz6057-reuse-namehelp (Based on branch lerner/bz5922-installed-package-name) -------------- COMMIT MESSAGE -------------- commit de4c6353ca05f59571fb9044f883d889076ca1cb Author: Dave Lerner <[email protected]> Date: Wed Mar 26 15:49:43 2014 -0500 bitbake: toaster: unbuilt package dependency formats [YOCTO 6057] For a package shown on the package build dependency page, the dependent packages may be unbuilt packages, as indicated with the dependent package's size set to -1. This fix changes the build template to use the same formatting functions for unbuilt dependent packages as the include package templates use for unbuilt dependent packages. Signed-off-by: Dave Lerner <[email protected]> --- .../templates/package_built_dependencies.html | 75 +++++++++----------- 1 file changed, 33 insertions(+), 42 deletions(-) ---------------------- TESTS EXPECTED RESULTS ---------------------- Setup: For qemux86, defaults, clean project directory run bitbake core-image-minimal Packages built not installed [found via query: select OP.build_id, OP.id, OP.name, OP.size from orm_package_dependency PD, orm_package OP where OP.id=PD.depends_on_id and PD.dep_type in (0,1) and OP.id not in (select package_id from orm_target_installed_package);] Case 1 runtime dependency has information: Select parent package: gst-plugins-bad-dev Verify libgstbasecamerabinsrc-0.10 is not muted and has no help NOTE: Use the following sqlite commands, queries and inserts, to force data into database for an 'unbuilt' runtime dependency (which seems impossible to me, but add the test anyways). sqlite> insert into orm_package(build_id, installed_name, installed_size, size, name, version, license, description, section, summary, revision) values (1, '', 0, -1, 'daves package', '', '', '', '', '', ''); sqlite> select build_id, id from orm_package where name like 'dave%'; build_id = 1 id = 10355 sqlite> select build_id, id from orm_package where name = 'acl-dbg'; build_id = 1 id = 4592 insert into orm_package_dependency (package_id, depends_on_id, dep_type) values (4592, 10355, 0); Case 2 runtime dependendency has no information Select parent package: acl-dbg Verify muted pacakge with hover help for 'daves package' Case 3 other dependency has information Select parent package: acl-dbg Verify eglibc-dbg is unmuted Case 4 other dependency has no information Select parent package: acl-dbg Verify libacl-dbd is muted without size or version appearing. ------------------------------------- ADDITIONAL STANDARD REGRESSION TESTS ------------------------------------- HTML5 validation on acl-dbg page: Passed whitespace-eol-check: Passed -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
