Hi Farrell, Can you please rebase this patch on top of latest origin/master ?
Thank you, Alex On Fri, Apr 4, 2014 at 12:43 PM, Barros Pena, Belen < [email protected]> wrote: > On 03/04/2014 20:00, "Wymore, Farrell" <[email protected]> > wrote: > > >Hi Belen, > > > >I just pushed an amended fwymore/sortcol branch. > > This is working beautifully :) > > Thanks! > > Belén > > > >I believe this implements > >what we discussed. Please let me know what you think. Thanks in advance. > > > > - fw > > > >-----Original Message----- > >From: Barros Pena, Belen [mailto:[email protected]] > >Sent: Thursday, April 03, 2014 9:41 AM > >To: Wymore, Farrell > >Subject: Re: [review requested] column sort order > > > > > > > >On 03/04/2014 16:33, "Wymore, Farrell" <[email protected]> > >wrote: > > > >>Hi Belen, > >> > >>No problem. Don't worry about it. Sometime you have to see/experience a > >>change before you can really evaluate it. > >> > >>So to paraphrase, the hide/show columns should occur immediately with > >>each checkbox click while the resorting, If necessary, should occur > >>only when the menu is closed. > > > >Yes, that's exactly it > > > >> > >>I'll have to think about how to implement this because we're even > >>further separating the actions when a checkbox is clicked. Some actions > >>are performed immediately while others are delayed. > >> > >>BTW, the js magic was necessary only because I couldn't figure out how > >>to attach an onclose event to the menu - I had to create my own onclose > >>event. > > > >That is the drawback of using the Bootstrap framework. Now that you are > >working with us, maybe we should start thinking about replacing some of > >the framework controls with custom controls. But that's 1.7 material :) > > > >Thanks!! > > > >> > >> - fw > >> > >> > >>-----Original Message----- > >>From: Barros Pena, Belen [mailto:[email protected]] > >>Sent: Thursday, April 03, 2014 4:42 AM > >>To: Wymore, Farrell > >>Subject: Re: [review requested] column sort order > >> > >>Hi Farrell, > >> > >>Well, this does work as expected. I am pretty impressed with the js > >>magic! > >>:) > >> > >>Although the price we are paying is that you no longer get immediate > >>feedback when you select and deselect checkboxes, since all changes in > >>the Edit columns menu now take place when the menu is dismissed. This > >>does feel a bit clunkier, since the interface does not immediately > >>respond to my selections. And yes, I am aware that I did say that's the > >>way it should > >>behave: I should have thought harder before speaking :( > >> > >>Please don't throw things at me, but would it be too much to ask if we > >>try to show / hide the columns on selecting / deselecting the > >>checkboxes, and apply the sorting change when I dismiss the menu? I am > >>not sure how difficult this is to do, though. > >> > >>I am really sorry about all the back and forth. If you feel > >>this is too hard, just let me know. I really appreciate all the effort > >>you have put into this already :) > >> > >>Cheers > >> > >>Belén > >> > >> > >>On 02/04/2014 18:20, "Wymore, Farrell" <[email protected]> > >>wrote: > >> > >>>Hi Belen, > >>> > >>>I just pushed the fwymore/sortcol branch again. The code had to > >>>change extensively to accommodate the desired interaction model. This > >>>would have been a bit simpler if I could get an onclose event for the > >>>popup. > >>>Unfortunately, I couldn't determine the popup object id so I > >>>implemented my own. > >>> > >>> - fw > >>> > >>>-----Original Message----- > >>>From: Barros Pena, Belen [mailto:[email protected]] > >>>Sent: Wednesday, April 02, 2014 2:07 AM > >>>To: Wymore, Farrell; Reyna, David > >>>Subject: Re: [review requested] column sort order > >>> > >>> > >>> > >>>On 01/04/2014 18:56, "Wymore, Farrell" <[email protected]> > >>>wrote: > >>> > >>>>Hi Belen, > >>>> > >>>>I fussed with sortcol a bit more. For the longest time it continued > >>>>to work fine until I tried some corner cases. Then it started to > >>>>misbehave. > >>>>The solution may not be as simple as I originally thought... > >>> > >>>This kind of stuff is probably not easy with our current > >>>implementation > >>>model: our front end is too dumb. In all honestly, I rather don't > >>>waste any more of your time on this. Can we try the disabling solution > >>>instead? > >>>It will prevent people from hiding the column they are currently > >>>sorting on, which in the end is kind of what we want :) > >>> > >>>Thanks!! > >>> > >>>Belén > >>>> > >>>> - fw > >>>> > >>>> > >>>> > >>>>-----Original Message----- > >>>>From: Barros Pena, Belen [mailto:[email protected]] > >>>>Sent: Tuesday, April 01, 2014 7:04 AM > >>>>To: Reyna, David; Wymore, Farrell > >>>>Subject: Re: [review requested] column sort order > >>>> > >>>>This is the commit I am on in fwymore/sortcol > >>>> > >>>>76c499627a5cb33a33bb6a81d8130e5112150549 > >>>> > >>>>Instead of organising a Webex session just for this, should we look > >>>>at it tomorrow during the weekly call? > >>>> > >>>>Cheers > >>>> > >>>> > >>>>Belén > >>>> > >>>>On 31/03/2014 18:07, "Reyna, David" <[email protected]> wrote: > >>>> > >>>>>If we need to do a WebEx session to visually and directly compare > >>>>>our results, let me know and I will set it up. > >>>>> > >>>>>- David > >>>>> > >>>>> > >>>>>> -----Original Message----- > >>>>>> From: [email protected] [mailto:toaster- > >>>>>> [email protected]] On Behalf Of Wymore, Farrell > >>>>>> Sent: Monday, March 31, 2014 9:48 AM > >>>>>> To: BARROS PENA, BELEN > >>>>>> Cc: [email protected] > >>>>>> Subject: Re: [Toaster] [review requested] column sort order > >>>>>> > >>>>>> Hi Belen, > >>>>>> > >>>>>> I retested with both Chrome and Firefox. Both work as expected - > >>>>>>take no action until the popup-menu is closed. > >>>>>> I checked the branch and the most recent check-in. All appears to > >>>>>>be correct. > >>>>>> There is one more possibility which I haven't been able to verify > >>>>>>yet - git could be lying to me. > >>>>>> > >>>>>> Another thing you could try: > >>>>>> 1) Make sure you have the most recent fwymore/sortcol branch > >>>>>> 2) Stop toaster > >>>>>> 3) Start toaster > >>>>>> 4) Clear the cache in your browser (I didn't have to do this) > >>>>>> 5) Test > >>>>>> > >>>>>> This procedure may be necessary because javascript functions (and > >>>>>>other > >>>>>> stuff) may get cached in either the server and/or the browser even > >>>>>>if the enclosing html has changed. > >>>>>> BTW, the same thing happens with css data. > >>>>>> > >>>>>> - fw > >>>>>> > >>>>>> -----Original Message----- > >>>>>> From: Barros Pena, Belen [mailto:[email protected]] > >>>>>> Sent: Monday, March 31, 2014 9:12 AM > >>>>>> To: Wymore, Farrell > >>>>>> Cc: [email protected] > >>>>>> Subject: Re: [review requested] column sort order > >>>>>> > >>>>>> > >>>>>> > >>>>>> On 31/03/2014 16:45, "Wymore, Farrell" > >>>>>> <[email protected]> > >>>>>> wrote: > >>>>>> > >>>>>> >Hi Belen, > >>>>>> > > >>>>>> >What browser are you using to test? I'm using Chrome - everything > >>>>>> >works as expected. > >>>>>> > >>>>>> Firefox 28, but just tried it with Chrome 33 and it doesn't seem > >>>>>> to be working either :/ > >>>>>> > >>>>>> > > >>>>>> > - fw > >>>>>> > > >>>>>> > > >>>>>> >-----Original Message----- > >>>>>> >From: Barros Pena, Belen [mailto:[email protected]] > >>>>>> >Sent: Monday, March 31, 2014 2:44 AM > >>>>>> >To: Wymore, Farrell > >>>>>> >Cc: [email protected] > >>>>>> >Subject: Re: [review requested] column sort order > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> >On 28/03/2014 19:25, "Wymore, Farrell" > >>>>>> ><[email protected]> > >>>>>> >wrote: > >>>>>> > > >>>>>> >>Hi Belen, > >>>>>> >> > >>>>>> >>I think the fwymore/sortcol branch is now in good shape. I also > >>>>>> >>tried all of your tests indicated below and they all appear to > >>>>>> >>have the expected behavior. Please try another review. > >>>>>> > > >>>>>> >Hi Farrell, > >>>>>> > > >>>>>> >This is still not working for me. If I hide the .sorted column > >>>>>> >and then take any other action in the menu, the menu will close > >>>>>> >by > >>>>>>itself. > >>>>>> > > >>>>>> >I just don't think this is ever going to work well while > >>>>>> >re-sorting needs a page refresh. Could we try the alternative > >>>>>> >solution instead, > >>>>>>i.e. > >>>>>> >disable the checkbox for the .sorted column? > >>>>>> > > >>>>>> >Thanks! > >>>>>> > > >>>>>> >Belén > >>>>>> > > >>>>>> >> > >>>>>> >>Thanks in advance - fw > >>>>>> >> > >>>>>> >> > >>>>>> >>-----Original Message----- > >>>>>> >>From: Barros Pena, Belen [mailto:[email protected]] > >>>>>> >>Sent: Friday, March 28, 2014 11:13 AM > >>>>>> >>To: Wymore, Farrell > >>>>>> >>Cc: [email protected] > >>>>>> >>Subject: Re: [review requested] column sort order > >>>>>> >> > >>>>>> >> > >>>>>> >>On 28/03/2014 18:09, "Wymore, Farrell" > >>>>>> >><[email protected]> > >>>>>> >>wrote: > >>>>>> >> > >>>>>> >>>This works for me. I have been fussing with this a bit more > >>>>>> >>>(mainly dealing with git problems) since I checked in the first > >>>>>> >>>change this morning. I have a couple of things I need to clean > >>>>>>up. > >>>>>> >>>Let me do > >>>>>>that. > >>>>>> >>>I'll let you know when to try again. Thanks. > >>>>>> >> > >>>>>> >>Thanks! and sorry for all the back and forth. > >>>>>> >> > >>>>>> >>> > >>>>>> >>> - fw > >>>>>> >>> > >>>>>> >>>-----Original Message----- > >>>>>> >>>From: Barros Pena, Belen [mailto:[email protected]] > >>>>>> >>>Sent: Friday, March 28, 2014 11:01 AM > >>>>>> >>>To: Wymore, Farrell > >>>>>> >>>Cc: [email protected] > >>>>>> >>>Subject: Re: [review requested] column sort order > >>>>>> >>> > >>>>>> >>>Hi Farrell, > >>>>>> >>> > >>>>>> >>>Thanks for this. With your changes, the following works > >>>>>>correctly: > >>>>>> >>> > >>>>>> >>>* Sort the packages table by Size > >>>>>> >>>* Open the Edit columns menu > >>>>>> >>>* Deselect the Size column > >>>>>> >>>* Close the Edit columns menu > >>>>>> >>> > >>>>>> >>>When the menu closes, the Package sorting is applied. Nice! :) > >>>>>> >>> > >>>>>> >>>But if I try to do more than one thing in the Edit columns > >>>>>> >>>menu, the page refresh is triggered before I dismiss the menu. > >>>>>>Try this: > >>>>>> >>> > >>>>>> >>>* Go to the Packages table > >>>>>> >>>* Sort it by Size > >>>>>> >>>* Open the Edit columns menu > >>>>>> >>>* Deselect the Size column > >>>>>> >>>* Select the Size column again > >>>>>> >>>* Then close the "Edit columns" menu > >>>>>> >>> > >>>>>> >>>The resorting is triggered before I dismiss the menu. > >>>>>> >>> > >>>>>> >>>So, I am starting to think this might be a bit too much work > >>>>>> >>>for an edge case. Would it be easier if we simply disable the > >>>>>> >>>checkbox for whichever column has the .sorted class applied? > >>>>>> >>>This means that when I sort by a certain column, if the > >>>>>> >>>checkbox for that column is not disabled by default, we disable > >>>>>> >>>it (add the disabled attribute to the input tag and the .muted > >>>>>> >>>class to the > >>>>>>label tag). > >>>>>> >>>That might be an easy thing to do with jQuery. > >>>>>> >>> > >>>>>> >>>Let me know what you think. > >>>>>> >>> > >>>>>> >>>Thanks!! > >>>>>> >>> > >>>>>> >>>Belén > >>>>>> >>> > >>>>>> >>> > >>>>>> >>> > >>>>>> >>>On 28/03/2014 16:42, "Wymore, Farrell" > >>>>>> >>><[email protected]> > >>>>>> >>>wrote: > >>>>>> >>> > >>>>>> >>>>Hi Belen, > >>>>>> >>>> > >>>>>> >>>>I have amended this branch to have the indicated behavior - no > >>>>>> >>>>action taken until the pop-up is closed by the user - it > >>>>>> >>>>passes the test below. > >>>>>> >>>> > >>>>>> >>>> - fw > >>>>>> >>>> > >>>>>> >>>>-----Original Message----- > >>>>>> >>>>From: Barros Pena, Belen [mailto:[email protected]] > >>>>>> >>>>Sent: Friday, March 28, 2014 4:30 AM > >>>>>> >>>>To: Wymore, Farrell > >>>>>> >>>>Cc: [email protected] > >>>>>> >>>>Subject: Re: [review requested] column sort order > >>>>>> >>>> > >>>>>> >>>> > >>>>>> >>>> > >>>>>> >>>>On 27/03/2014 20:33, "Wymore, Farrell" > >>>>>> >>>><[email protected]> > >>>>>> >>>>wrote: > >>>>>> >>>> > >>>>>> >>>>>Hi Belen, > >>>>>> >>>>> > >>>>>> >>>>>Please review the correction for the column sort order issue > >>>>>>#5919. > >>>>>> >>>> > >>>>>> >>>>Hi Farrell, > >>>>>> >>>> > >>>>>> >>>>This is behaving a bit funny. The sorting change should > >>>>>> >>>>trigger only when the user closes the "Edit columns" menu, and > >>>>>> >>>>the "Edit > >>>>>>columns" > >>>>>> >>>>menu should only close when the user closes it. > >>>>>> >>>> > >>>>>> >>>>I should be able to do something like: > >>>>>> >>>> > >>>>>> >>>>* Go to the Packages table > >>>>>> >>>>* Sort it by Size > >>>>>> >>>>* Open the Edit columns menu > >>>>>> >>>>* Deselect the Size column > >>>>>> >>>>* Select the Size column again > >>>>>> >>>>* Then close the "Edit columns" menu > >>>>>> >>>> > >>>>>> >>>>And the table should still be sorted by Size. > >>>>>> >>>> > >>>>>> >>>>Right now, when I deselect the column with the sorting > >>>>>> >>>>applied, the "Edit columns" menu closes by itself after a > >>>>>> >>>>certain amount of > >>>>>>time: > >>>>>> >>>>that should never happen. That menu should only ever be > >>>>>> >>>>dismissed by clicking the button or outside the menu area when > >>>>>> >>>>the menu is > >>>>>>open. > >>>>>> >>>>Dismissing it should trigger the sorting change when needed. > >>>>>> >>>> > >>>>>> >>>>Cheers > >>>>>> >>>> > >>>>>> >>>>Belén > >>>>>> >>>> > >>>>>> >>>>>I have applied this change to all displays that have tables > >>>>>> >>>>>with sortable/optional columns. > >>>>>> >>>>> > >>>>>> >>>>> > >>>>>> >>>>>Thanks in advance - fw > >>>>>> >>>>> > >>>>>> >>>>> > >>>>>> >>>> > >>>>>> >>>> > >>>>>> >>> > >>>>>> >>> > >>>>>> >> > >>>>>> >> > >>>>>> > > >>>>>> > > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> _______________________________________________ > >>>>>> toaster mailing list > >>>>>> [email protected] > >>>>>> https://lists.yoctoproject.org/listinfo/toaster > >>>> > >>>> > >>> > >>> > >> > >> > > > > > > -- > _______________________________________________ > toaster mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/toaster > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
