Hi Farrell, Sorry for the delay. This is looking pretty good now. Thanks for the work.
There seems to be just one glitch: it might be related to the cookie that saves the state of the "edit columns" menu for each page. Basically, if I make any changes in the "edit columns" menu after I land in the installed packages table, the changes get remembered, and clicking the license manifest link will no longer display the right columns. This is how you can reproduce this: 1. Clear the localhost cookies (just to start from the default states) 2. Select a build and click on "license manifest". This will show the correct columns in the packages included table (package, package version, license and recipe). 3. Click on the "edit columns" menu and select a new column, for example, Dependencies 4. Use he breadcrumb at the top of the page to go back to the build dashboard 5. Click on "license manifest" Outcome: the table shows the Dependencies column. Expected outcome: the table should not show the Dependencies column. Whenever I click the "license manifest" link, I should only see the Package, Package version, License and Recipe columns in the installed packages table. Let me know if you have any questions. Cheers Belén On 30/05/2014 20:34, "Wymore, Farrell" <[email protected]> wrote: >Hi Belen, > >I think branch fwymore/target-refactor is squared away now. Please give >it a try. >It turned out that there were lots of little problems to fix. Thanks in >advance. > > - fw > > >-----Original Message----- >From: Barros Pena, Belen [mailto:[email protected]] >Sent: Thursday, May 29, 2014 2:20 AM >To: Wymore, Farrell >Subject: Re: [review request] target refactor/license manifest link > >Hi Farrell, > >Sorry for the delay in replying: I was out of the office yesterday. The >answer to this one is quite simple: the link should be on the <dt> tag, >not on the <dd> tag. The reason is that if we link the <dd> tag, which >contains the path to the license manifest, people might think that they >will be downloading the file, when in reality we are just sending them to >a page in Toaster that shows the same information as the license manifest >file. > >I am happy to talk on Skype, though. I can do today at 10am your time. My >Skype id is is belenbarrospena. > >Cheers > >Belén > >On 28/05/2014 17:56, "Wymore, Farrell" <[email protected]> >wrote: > >>Hi Belen, >> >>I may have gotten the sense of the columns mixed up. This is easy to >>correct. >>What got me completely confused is your picture indicating the license >>manifest and target images are not links. How else do you get to these >>pages? Are these links conditional somehow? >> >>I'd be happy to discuss this via skype. My skype address is 'fwymore' >>or 'Farrell Wymore'. >>Please indicate a convenient time. Thanks and I hope to hear from you >>soon. >> >> - fw >> >> >> >>-----Original Message----- >>From: Barros Pena, Belen [mailto:[email protected]] >>Sent: Tuesday, May 27, 2014 3:16 AM >>To: Wymore, Farrell >>Cc: Reyna, David; [email protected] >>Subject: Re: [review request] target refactor/license manifest link >> >>Hi Farrell, >> >>This doesn't seem to be working for me: when I click on the license >>manifest link the columns shown in the installed packages table are >>still not the right ones (they should be Package, Package version, >>License and Recipe, but I see Package, Package version, Size, >>Dependencies, Reverse dependencies and Recipe). Also: >> >>* The "Size" column heading is missing (see attached screenshot >>table-heading-missing.png) >>* The license manifest path is a link (but it should not be). See >>attached links.png >>* The "Image files" dt is nested inside an anchor tag: that anchor tag >>should not be there. See attached links.png >> >>Let me know if you have any questions. >> >>Cheers >> >>Belén >> >> >>On 22/05/2014 23:15, "Wymore, Farrell" <[email protected]> >>wrote: >> >>>Hi Belen, >>> >>>I finally had a chance to finish up a couple bugs: >>>6291 >>>refactor target display >>><https://bugzilla.yoctoproject.org/show_bug.cgi?id=6291> and >>>6079 >>>The license manifest link in the build dashboard is going to the wrong >>>page <https://bugzilla.yoctoproject.org/show_bug.cgi?id=6079> >>> >>>and related though this was fixed some time ago >>> >>>5936 >>>Add license manifest path to the image dashboard page >>><https://bugzilla.yoctoproject.org/show_bug.cgi?id=5936> >>> >>>Please review. They¹re all on branch fwymore/target-refactor. Thanks >>>in advance. >>> >>>- >>>fw >>>- >>> >>> >> >> > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
