On 02/06/2014 19:16, "Wymore, Farrell" <[email protected]> wrote:
>Hi Belen, > >I believe I have accommodated all of the conditions needed for displaying >the message. Nice :) Just a few minor tweaks: * Can we take the <div> with the .alert class outside of the definition list <dl></dl>? That will get the white space right. * Can we wrap the path (../poky/build/tmp/deploy) inside a <code> tag? * The sentence "view the license manifest information" should be a link that behaves exactly like the "license manifest" link (i.e. it brings you to the installed packages table showing the package, package version, license and recipe columns). And that's it. Cheers Belén >This branch corrects bug 6094. Please review. Thanks in advance. > > - fw > >-----Original Message----- >From: Barros Pena, Belen [mailto:[email protected]] >Sent: Thursday, May 29, 2014 2:30 AM >To: Wymore, Farrell >Subject: Re: [review-request] display message if there is no image > >On 27/05/2014 16:34, "Wymore, Farrell" <[email protected]> >wrote: > >>This is confusing. Root_fs is not generated anytime you build something >>that does not generate an image - like quilt - or when you get an >>error. I thought this was when you wanted the message to be produced? >>Is this not the case? > >Ok, this is a more complicated one to explain. I am going to go through >the different cases: > >1) If I build a target that does not generate an image (for example, >quilt), the build dashboard does not include an image content module. See >case1.pdf attached. > >2) If the build fails, we assume that no image has been generated, and >the build dashboard does not include an image content module. See >case2.pdf attached. > >3) If I build a target that generates an image (like core-image-minimal) >and the build completes successfully, but no license manifest or rootfs >files have been generated (this happens when do_rootfs does not execute >and it is kind of an edge case: it will not happen often), then the >dashboard page does include an image content module that looks like the >one shown at > >https://bugzilla.yoctoproject.org/attachment.cgi?id=1888 > >I hope this explains. Otherwise we can go through it over Skype. > >Cheers > >Belén > > >> >>Should the message be produced if you build an image producing target >>but you get an error and no image is produced? >> >> - fw >> >> >>-----Original Message----- >>From: Barros Pena, Belen [mailto:[email protected]] >>Sent: Tuesday, May 27, 2014 5:33 AM >>To: Wymore, Farrell >>Cc: Reyna, David; [email protected] >>Subject: Re: [review-request] display message if there is no image >> >> >>On 23/05/2014 20:32, "Wymore, Farrell" <[email protected]> >>wrote: >> >>>Hi Belen, >>> >>>The branch fwymore/empty-image corrects bug 6094. >>>There are 3 cases: >> >>I think I need some help understanding the 3 cases. >> >>>1) there is no target data, >> >>I am not sure what this case means. Is it when no information about the >>target is collected because of some error? Or is it when the target of >>a build is not an image recipe, for example, I build curl instead of >>core-image-blah? >> >>>and 2) there is some >>>target data but no images, >> >>Is this when I build core-image-blah but do_rootfs does not execute and >>therefore there is no license manifest or rootfs files generated? >> >>>and 3) there are multiple targets, one or more did not generate an >>>image. >> >>Is this if for example I build core-image-blah and curl within the same >>build? >> >>The case the design was made for was my comment on case 2: I build >>core-image-blah but do_rootfs does not execute and therefore there is >>no license manifest or rootfs files generated. In such cases, the image >>content module should like this >> >>https://bugzilla.yoctoproject.org/attachment.cgi?id=1888 >> >>But in your branch looks like the attached no_do_rootfs.png >> >>Cheers >> >>Belén >> >> >> >>>Case 2 is a minimal version of >>>case 3 and should be tested a bit more thoroughly. The code should >>>handle all 3 cases. Thanks in advance. >>> >>>- >>>fw >>>- >>> >>> >>> >> >> > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
