Hi Belén, I have done a pass at your updated design document. You seem to have fully addressed the edge cases and multiple workflow possibilities.
I have just a few comments. 1) Page 16 The term "Import Layers" implies to me a copy action (e.g. Word, web design programs, Photoshop, iMovie, ...). I wonder if an alternate phrase like "Register Layers" or "Include Layers" would be closer to the actual action? 2) Page 19 There is a state where you write "Toaster does not know which added layer provides the target." Can I assume that this only occurs when the user manually adds a target but Toaster cannot find a layer that provides it? If I understand correctly, when toaster cannot not find a parent layer it will initially leave the target in blue, and only move it to red if a build is attempted and it fails? In other words, even if Toaster cannot associate a target with a layer it will still treat it normally (albeit without pop-up parent layer information)? I see that you cover the build-failure case on page 24, but I did not notice where you cover the layer-not-found-but-target-works case. 3) Page 21, et. al. As a nit-pick, I would suggest the alternate wording "From the layer information that Toaster has currently, it thinks ...", to put the actor (Toaster) in the first part of the sentence fragment, and to also not end that fragment with a verb (I think that my mother frowns on that). 4) Page 24 and Page 25 Your design shows two places to list possible missing layers, once in the layer list hovers and once in the build results. Do you really want this duplication? I just wonder if it is worth considering a consolidation in order to not do the display and computation code twice, or if ease-of-use justifies this effort? 5) Page 32 You write "... since Toaster will not know about machines from imported layers that have not been parsed yet". This is of course a general limitation of bitbake for the pre-configuration state. My general question is this then: should we and can we provide an action (perhaps a simple build target) that will trigger bitbake to do that initial parse, so that the user can directly and immediately improve the information available to them? - David > -----Original Message----- > From: Barros Pena, Belen [mailto:[email protected]] > Sent: Tuesday, July 08, 2014 6:20 AM > To: Reyna, David; DAMIAN, ALEXANDRU; Lerner, Dave; Ravi Chintakunta > ([email protected]); Amit Kumar Chaudhary; Wymore, Farrell > Cc: [email protected] > Subject: Re: More Projects design (YP6232) > > And still a bit more: how to change the "Project details" (the name, the > owner, and that kind of thing). > > Design document attached to Bugzilla entry: > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=6232 > > > New stuff in pages 39 to 42. > > Belén > > On 07/07/2014 15:49, "Barros Pena, Belen" <[email protected]> > wrote: > > >I've added: > > > >* Queued and cancelled builds (pages 10-11) > >* Quick add option for targets (pages 27-29) > >* Deleting layers and targets (page 30) > >* Changing machine and distro (pages 31-38) > > > >Design document attached to Bugzilla entry: > > > >https://bugzilla.yoctoproject.org/show_bug.cgi?id=6232 > > > >Cheers > > > >Belén > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
