On 05/12/2014 15:23, "Damian, Alexandru" <[email protected]> wrote:
>Hello, > > >Can you please review the >poky-contrib branch > > >adamian/download_cap Hi Alex, This is in pretty good shape. I've found some small issues though. There they go: * the download icons are missing their tooltips * the icon to download the cooker log is missing from the project builds page and the all projects page * When I click to download the cooker log, I get this error Environment: Request Method: GET Request URL: http://0.0.0.0:8000/toastergui/build/1/artifact/cookerlog/id/1 Django Version: 1.6 Python Version: 2.7.6 Installed Applications: ('django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.messages', 'django.contrib.sessions', 'django.contrib.admin', 'django.contrib.staticfiles', 'django.contrib.humanize', 'orm', 'toastermain', 'south', 'bldviewer', 'toastergui', 'bldcontrol') Installed Middleware: ('django.middleware.common.CommonMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.middleware.csrf.CsrfViewMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'django.contrib.messages.middleware.MessageMiddleware') Traceback: File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py" in get_response 114. response = wrapped_callback(request, *callback_args, **callback_kwargs) File "/home/yocto/poky/bitbake/lib/toaster/toastergui/views.py" in build_artifact 2822. fsock = b.buildrequest.environment.get_artifact(file_name) File "/home/yocto/poky/bitbake/lib/toaster/bldcontrol/models.py" in get_artifact 78. return open(path, "r") Exception Type: IOError at /toastergui/build/1/artifact/cookerlog/id/1 Exception Value: [Errno 2] No such file or directory: u'/home/yocto/poky/build/tmp/log/cooker/qemux86/20141205163605.log' * the icon to download the failed task logs is missing from the project builds page and the all projects page * We should add the download link for the failed task logs to the tasks table in the recipe details page (sorry, forgot to put this in the design document) * for the license manifest file, we should not show the path to the file, but 2 links: 1 to view the information in Toaster and a second one to download the manifest file (see page 16 of design document) * the other artifacts are listing the links to the real files (the links shouldn't be there) Thanks! Belén > > > >This implements the needed changes to allow users to download relevant >files through the user interface. > >It is rebased on the current toaster/master > > >Thank you, >Alex > > >-- >Alex Damian >Yocto Project > >SSG / OTC > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
