On 18/12/2014 23:55, "Michael Wood" <[email protected]> wrote:
>Review request for poky-contrib michaelw/toaster/layer-details
Hi Michael,
Thanks for this. Some comments about the interface:
* The breadcrumb is missing the 'all layers' item and the name of the
current layer. It says:
all builds > project_name > Layer Details
But is should say:
all builds > project_name > All layers > layer_name (revision)
* The layout is a bit messed up: the heading is not aligned properly. The
structure should be:
<div class="container-fluid top-padded">
<div class="row-fluid">
<div class="section">
<!-- the breadcrumb goes here -->
</div>
<div class="span11">
<!-- the page heading goes here -->
</div>
<div class="span7">
<!-- the tabs and the tab content go here -->
</div>
<div class="span4 well">
<!-- this is the right column -->
</div>
<div>
</div>
* When the page heading shows the first 10 characters of the commit SHA,
we are missing the tooltip on hover that shows you the complete SHA (see
page 9 of the design document)
NOT EDITABLE VERSION
* Commit SHA is showing instead of the branch name. For example, if you
select a layer that has a branch name in the 'branch, tag or commit'
column in the all layers page, you will see that the layer details page is
showing a commit in the page heading, instead of the branch name.
* In the right hand column, the line height inside the <dd> items is not
quite right. It seems to be 25px instead of 20px, although I can see that
it is set to 20px in default.css. If I change the span tag to a p tag, the
line height is the correct one.
* In the layer details tab, the Yocto Project compatibility list item can
go.
* In the layer details tab, the "Last commit" information is missing
* There is something funky going on with the information in the layer
details tab. It might be related to empty information. If you select the
meta-fsl-arm-extra layer, for example, that layer doesn't seem to have a
subdirectory, so all other items of information shift up, so you see a
commit next to the 'repository subdirectory' label, and the layer
dependencies split between the Yocto Project compatibility and the
Dependencies items. If a bit of information is empty, we remove the whole
list item (both dt and dd tags), so if a layer does not have a
subdirectory, we don't who the <dt>Subdirectory<dt> element either.
* The 'Git repository URL' and the 'Subdirectory' values are missing the
external links (see page 15 of the design document)
* In the 'Targets' tab, when the layer is not added to the project and the
number of targets is > 0, the big button above the table should say: "Add
the <layer_name> layer to your project to enable these targets", and all
the 'Build target' buttons in the table should be inactive
* The targets table should be sorted by target name in ascending
alphabetical order
* In the targets table, the external link to the layer index next to the
target name is missing (see page 21 of the design document)
* In tables with more than 10 rows, the search is missing (see pages 25 to
27 of the design document)
* In the targets tables with more than 10 rows, the number of entries
displayed at the bottom of the table can go, the pagination should be
left-aligned with the table and horizontally aligned to the show rows
control. You can see what I mean at
http://www.yoctoproject.org/toaster/layer-details-with-search.html
* In the not editable version of the page, when the targets table is
empty, the notification says: "The <layer_name> layer does not provide any
targets". It is likely that the information coming from the layer source
is correct, and there will never be any targets there.
* In the 'Machines' tab, when the layer is not added to the project and
the number of machines is > 0, the big button above the table should say:
"Add the <layer_name> layer to your project to enable these machines", and
all the 'Select machine' buttons in the table should be inactive
* The help bubble next to the "Select machine" table heading can go
* The machines table should be sorted by machine name in ascending
alphabetical order
* The machines table is missing the external link to the machine file (see
page 23 of the design document)
* In the machine tables with more than 10 items, we are missing the
search, show rows and pagination controls
* In the not editable version of the page, when the machines table is
empty, the notification says: "The <layer_name> layer does not provide any
machines". It is likely that the information coming from the layer source
is correct, and there will never be any targets there.
* When I add / delete a layer to the project from this page, the tooltip
and the notification are missing (see pages 28 to 30 of the design
document)
* When I click the 'Select machine' buttons, nothing happens
* Sometimes, the add layer button does nothing, other times it works. I am
not sure, but it seems to work when the layer you are trying to add has
unsatisfied dependencies, but not when the layer doesn't have any
unsatisfied dependencies.
EDITABLE VERSION
* When a field is empty, it should say "not set" instead of "none" and
should have the .muted class applied
* In the editable state, the button labels should be 'save' and 'cancel',
instead of 'change' and 'cancel'. I know this sounds crazy, but there is a
reason why I set this to 'save'. I don't quite remember right now, but
probably so that it makes sense in all contexts.
* If a value is empty, when you click on the 'change' icon, the value of
the input field is set to 'none'. In this case, the input field should be
empty
* When you are editing something, while the input field is empty, the
'save' button should be disabled. This is important because it is the way
we make sure you don't set mandatory values, like the 'Git repo URL' to
blank (something you can do right now).
* Non-mandatory items like Summary and Description should have a 'delete'
icon whenever they have a value (see page 13 of the design document).
* In the right-hand column, the edit forms should have 20px of bottom
margin, to separate them a bit from the rest of the definition list. You
can see it at http://yoctoproject.org/toaster/layer-details-imported.html
* the default.css file has 2 dd form declarations, one after the other. We
should not have the 2 of them
* In the layer details tab, we need to add 10px of top margin to the <dt>
element when you click the 'edit' button to make sure it correctly aligns
horizontally with the form. You can check it out here
http://yoctoproject.org/toaster/layer-details-imported.html
>
>commit 7f6b4a2f2d9b1e83593335be09801f7b2efa812a
>Author: Michael Wood <[email protected]>
>Date: Thu Dec 11 18:32:54 2014 +0000
>
> bitbake: toaster: Add layer details page feature
>
> This commit adds the layer details page which shows the metadata
>for the
> layer such as layer description, machines associated with the layer
>as well
> as the targets provided.
> If the layer is an imported layer this page also allows you to update
> the layer's configuration.
> From this page you can add/remove the layer from the current project
>
> Signed-off-by: Michael Wood <[email protected]>
>
>
>Thanks,
>
>Michael
>--
>_______________________________________________
>toaster mailing list
>[email protected]
>https://lists.yoctoproject.org/listinfo/toaster
--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster
