Hi, yes, I think it's a good idea to track the separate issues into different bugs. :)
Thanks, Alex On Wed, Jan 7, 2015 at 9:31 AM, Barros Pena, Belen < [email protected]> wrote: > > > On 06/01/2015 22:28, "Damian, Alexandru" <[email protected]> > wrote: > > >Hello, > > > > > >I pushed the latest changes to the Project page here. > > > > > >adamian/20141216-projectpage-6587 > > Thanks for this, Alex. I've only reviewed this quickly, and this is what > I've found: > > * Machine, Project name and Release are missing the slide down / up > animations when you click the 'Change' icon > * When the release is in the editable state, the 'Cancel' link must always > be enabled. Otherwise I cannot return to the non-editable state. Right now > is disabled until I change the release value > * We should sort all suggestions (for layers, targets and machines) in > alphabetical order. > * Machine suggestions should show the layer name and revision, exactly > like the target suggestions do > * In both target and machine suggestions, layer names should be > searchable. This is handy for when you are looking for targets / machines > provided by a certain layer, since you can type the layer name to get a > list. > > Now, the page is getting into shape, so I think we can probably set the > main bug (6587) to resolved once this is merged and I can open separate > issues for the things above and any other stuff we find. Would that be ok? > > Thanks! > > Belén > > > > > > > > > >This should bring the project page in line with the design, except for > >error handling in the "invalid machine" and "invalid distro" cases - only > >"missing target" error handling is present. > > > > > >Can you please review the code and let me know if I can push ? > > > > > >Cheers, > >Alex > > > > > >-- > >Alex Damian > >Yocto Project > > > >SSG / OTC > > > > > > > > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
