Ok, crisis averted, extra exception handling added. The commit should be good now.
dreyna/all_projects_6682 - David From: [email protected] [mailto:[email protected]] On Behalf Of Reyna, David Sent: Wednesday, February 18, 2015 9:08 AM To: BARROS PENA, BELEN; DAMIAN, ALEXANDRU Cc: [email protected] Subject: Re: [Toaster] [review-request] 6682 - Implement changes needed in the "All Projects" page Hi Belen, For my All Projects page, I found an issue when displaying projects that have not been built yet (causes an error when looking up the FSTYPES to pretty print them). I am working on a fix, should have it within a few hours. - David _____________________________________________ From: Reyna, David Sent: Wednesday, February 18, 2015 12:36 AM To: [email protected]<mailto:[email protected]>; Damian, Alexandru ([email protected]<mailto:[email protected]>) Cc: [email protected]<mailto:[email protected]> Subject: [Toaster] [review-request] 6682 - Implement changes needed in the "All Projects" page Hi Belen and Alex, 1) I have implement all but the sorting (see below) changes for the "All Projects" page. dreyna/all_projects_6682 2) I could not get the sorting to work with the synthetic "get_last_*" values. It appears that these "def" values are not accepted as sortable columns. Unless Alex has some magic I think we should skip this enhancement. * Here is the error: "Invalid ordering model:<class 'orm.models.Project'>(u'get_last_target', ['bitbake_version', 'build', 'buildrequest', 'created', u'id', 'layer_version', 'name', 'projectlayer', 'projecttarget', 'projectvariable', 'release', 'short_description', 'updated', 'user_id'])" * Here is the code snippet I had tested: Models.py:: Project() - search_allowed_fields = ['name', 'short_description', 'release__name', 'release__branch_name'] + search_allowed_fields = ['name', 'short_description', 'release__name', 'release__branch_name', 'get_last_target'] Views.py:: projects() {'name': 'Last target', 'clclass': 'ltarget', 'qhelp': "The last project build target(s): one or more recipes or image recipes", + 'orderfield': _get_toggle_order(request, "get_last_target"), + 'ordericon':_get_toggle_order_icon(request, "get_last_target"), + 'orderkey' : 'get_last_target', }, 3) Here is what is working [x] In the Edit columns menu, the "Last image files" checkbox only shows /hide the table heading, and not the cells in the table body [x] The 'last updated' column change the column heading to "last build' and move the column to right after the 'number of builds' one [x] The release in the table should link to the 'Project details' section of the corresponding project page [x] The data for the following columns is not being displayed: Machine, Number of builds, Last outcome, Last target, Last errors, Last warnings, Last image files [x] The heading should show the number of results returned when you search [x] The 'no results' page is not in place I also ported the fancy column entry formatting from the "builds" page. - David
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
