I just found a couple of other things, sorry: * If you add manually one of our default variables, I can briefly see an error alert coming up, then disappearing very quickly.
* When you add back SDKMACHINE, when you click the 'change' icon the Cancel button is disabled. * When you add back PACKAGE_CLASESS, the 'Save' button is disabled, so you cannot make any changes to the variable value Cheers Belén On 27/02/2015 12:10, "Barros Pena, Belen" <[email protected]> wrote: >Hi David, > >This is working great. I only have a couple of small comments (inline): > >On 27/02/2015 04:08, "Reyna, David" <[email protected]> wrote: > >>Hi Belén, >> >>This commit ³dreyna/hardcoded_submit_7246_7371³ fixes these items: >> >> 7246 ³Hardcoded variables in /configuration page² > >The only issue I've found is that the MACHINE variable is showing up in >the page. I think we should filter it out, particularly because the >validation you have added to the 'add variable' form for preventing people >setting the machine in this page. > >> 7371 ³Toaster managed mode: configuration variables page allows empty >>inputs into database² >> >> >> * Finally, I added/fixed code to enforced the blocking of the variables >>that are managed outside this page, specifically BBLAYERS and MACHINE >>which are handled by the project detail page. > >This is very nice, I found the message a bit confusing, because it gives >me a reason but does not tell me what to do. I know this might require >some hard coding, but could we have different messages for the MACHINE and >the BBLAYERS cases? > >So if you try to set the MACHINE, the message should say: > >"You cannot set this variable here. Please set the MACHINE in the project >main page" > >If you try to set BBLAYERS, the message should say: > >"You cannot set this variable here. Please add and remove layers in the >project main page" > >If this is too much and you rather use a single message, it could say: > >"You cannot set this variable here. Please set it in the project main >page" > >In all the above messages, "project main page" should be a link to the >project page. > > >I hope I am not asking too much. > >Thanks!! > >Belén > >> >>- David >> >> > >-- >_______________________________________________ >toaster mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/toaster -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
