Dave, this is in great shape. I've only found 2 issues, that I hope are kind of small:
* In the no results page, the link says: "show all objects". It should say all packages (to match the heading, the tab, and what we do everywhere else) * When you search, the number of results is not shown anywhere. The number of results should show in a label next to the Package table heading. The design is explained on page 5 of this document https://bugzilla.yoctoproject.org/attachment.cgi?id=1810 You can see it implemented in the layer details page. Thanks!! Belén On 03/03/2015 22:53, "Lerner, Dave" <[email protected]> wrote: >http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/recip >e_package_sort_6154 > >Implements fixes for 6154 recipe-packages detail sorting, searching, >pagination. > >Tests: >Viewing a qemux86 -64 core-image-full-cmdline build, then selection of > recipes -> (specified package) -> Packages tab >Then verify: > traversal from packages to other 3 tabs works > packages in table > Size 1st sort descending > Package 1st sort ascending > no packages for recipe (acl-native) > <package-version-rev> does not build any packages > < 10 packages (at) > verify no pagination widgets > verify no search bear > more than 500 packages glibc-locale > verify only pages 1-5 appear > verify picking page 5 centers page 5, same for page 7 > then selecting size reverts back to page 1, descendant size > search with results > gives right set > can add to search text string > remove [x] button deletes string and resets to unfiltered serch > search without results > No <packages> found > show all objects button clicked shows original 1st page > >Wc3 Validator >all pages show 2 errors in build popover, these errors ignored for this >review. > > < 10 packages(at) : ok > only 1 page of packages (acl) > 10 : ok > no packages for recipe (acl-native) : ok > more than 500 packages (glibc-locale) page 7 : ok > result from empty search : ok > >Comparison with defect attached spec: ok > >Comparison tag layout with Layer Detail Target Page: > span11, page-header, h1 : expected difference, recipe simpler > span7 > alertarea, dismiss alert : expected difference, not in recipe page > tabcontent button-place : expected diff, not in recipe > (targets/packages-built), table : expected diff, recipe adds >tablesorter > pagination : expected diff, recipe uses reload_params, targets >selfref href > >Comparison with layer Detail Page, empty search result: > no diffs in appearance > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
