> We're already hardcoding this IMAGE_INSTALL_append; can we simply add a > hardcode to prepend a space to the value just for this variable? If we > display > the value with the space when reloading the value it should be OK as far > as user perception goes.
Ok, let us just do that. We of course won't just display a space, the javascript would in fact enforce a prefixed space for the value. That insures that the space is passed to the backend. - David > -----Original Message----- > From: Paul Eggleton [mailto:[email protected]] > Sent: Thursday, March 12, 2015 8:03 AM > To: Reyna, David > Cc: BARROS PENA, BELEN; DAMIAN, ALEXANDRU; PURDIE, RICHARD; > [email protected] > Subject: Re: general solution proposed for 7394 "Toaster needs to add a > space to the value of IMAGE_INSTALL_append" > > The trouble is += won't work in the context it is being applied at the > moment > - we are using _append because it's the only way to force the value to be > added in spite of any other assignments. > > We're already hardcoding this IMAGE_INSTALL_append; can we simply add a > hardcode to prepend a space to the value just for this variable? If we > display > the value with the space when reloading the value it should be OK as far > as > user perception goes. > > On Thursday 12 March 2015 14:54:56 Reyna, David wrote: > > > With what we have left in the release, I rather > > > go for the simplest acceptable solution. > > > > Ok. We can do the full solution in YP-1.9. > > > > However, that leaves us with "IMAGE_INSTALL_append" being still > semantically > > wrong, and not a good foundation for the future. > > > > If we can rename it to "IMAGE_INSTALL_+=" (following my general > proposal), > > and make this single hardcoded exception, then we are talking a minimal > > change (a dozen lines of code). > > > > The other option is to just call it "IMAGE_INSTALL", with no syntax > sugar, > > and just make it work as a "+=" hardcoded in the background. > > > > - David > > > > > -----Original Message----- > > > From: Barros Pena, Belen [mailto:[email protected]] > > > Sent: Thursday, March 12, 2015 7:44 AM > > > To: DAMIAN, ALEXANDRU; Reyna, David; Paul Eggleton; PURDIE, RICHARD > > > Cc: [email protected] > > > Subject: Re: general solution proposed for 7394 "Toaster needs to add > a > > > space to the value of IMAGE_INSTALL_append" > > > > > > On 12/03/2015 14:09, "Damian, Alexandru" <[email protected]> > > > > > > wrote: > > > >In fact what we can do is have a pull down list in the page to > specific > > > >and select any of the supported special operators, and let the > javascript > > > >manipulate these special syntaxes. That way no one needs to > > > >memorize/learn about the supported operators, making the whole thing > more > > > >intuitive and self-directed. > > > > > > If we want to introduce operators, we'll need to provide controls in > the > > > configuration variables page to set them, together with help to > explain > > > what each of them means. Considering that we are implementing special > > > controls to ease the manipulation of certain variables, I would need > to > > > find a way of inserting the operator control so that it works in all > cases > > > (and not only when we simply have a text field to set the variable > value). > > > > > > > > > I raised this question when we were designing the variables page, and > the > > > answer was not to include operators. I would rather not do it now at > this > > > late stage, to be honest. With what we have left in the release, I > rather > > > go for the simplest acceptable solution. > > > > > > Cheers > > > > > > Belén > > -- > > Paul Eggleton > Intel Open Source Technology Centre -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
