This is fine ! :) Cheers, Alex
On Tue, Mar 17, 2015 at 3:45 PM, Lerner, David M (Wind River) < [email protected]> wrote: > Hi Alex, > Since you want this to be handled in the backend, I am reassigning the bug > to you and changing the state to NEW. > Dave > > > -----Original Message----- > > From: Damian, Alexandru [mailto:[email protected]] > > Sent: Tuesday, March 17, 2015 10:19 AM > > To: BARROS PENA, BELEN > > Cc: Lerner, Dave; [email protected] > > Subject: Re: [Toaster] [review-request] 7414-cut the prefix from layer > file paths for > > bitbake variables > > > > Hi, > > > > > > Sorry for the significant delay in addressing this patch - I've been a > bit overwhelmed. > > > > > > I am NOT taking this patch because of the way the layer matching is done. > > > > > > We already have local paths for layers present in the build in the Layer > object; we also > > know _where_ the build took place, for we have > > "build.buildrequest.buildenvironment.builddir" variable that holds the > path to the build > > directory. > > > > We must verify that the file path starts with one of the layer paths or > the build > > environment builddir path, and strip that leading path from the full > file path. > > > > > > I would also expect this to be done at data logging time instead of data > display time > > (i.e. in the buildinfohelper.py), with the distinct advantage of > speeding up page > > processing time. > > > > > > Thank you, > > > > Alex > > > > > > On Mon, Mar 16, 2015 at 3:41 PM, Barros Pena, Belen < > [email protected]> wrote: > > > > > > > > > > On 16/03/2015 14:14, "Lerner, Dave" <[email protected]> > wrote: > > > > >Hi Belen, > > > > > >> -----Original Message----- > > >> From: Barros Pena, Belen [mailto:[email protected]] > > >> Sent: Friday, March 13, 2015 9:17 AM > > >> To: Lerner, Dave > > >> Cc: [email protected] > > >> Subject: Re: [review-request] 7414-cut the prefix from layer > file paths > > >>for bitbake > > >> variables > > >> > > >> Hi Dave, > > >> > > >> This is looking good. But I've realised I forgot about > something. Not > > >>all > > >> files setting variables are inside a layer: some of them are > > >>configuration > > >> files inside the /build or /bitbake directories. > > >> > > >> I guess we should also cut those, showing only the path inside > the root > > >> source directory. So something like > > >> > > >> /home/user/poky/build/conf/local.conf > > >> > > >> Would show as > > >> > > >> build/conf/local.conf > > >> > > >> I am not fully sure if this is the right thing to do, so I'd be > > >>interested > > >> in hearing what you and the others think. > > >> > > >> I also realise this was not explicitly explained in the > original bug. If > > >> you want me to open a separate issue in Bugzilla, I can do so: > just let > > >>me > > >> know. > > > > > >Please open a separate bug and give Alex the ok for 7414. Layer > relative > > >makes sense to me, active-build-directory-relative does not, too > many > > >questions "what is the relative to?" are raised. > > > > > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/trim_v > > arpath_7414 <http://git.yoctoproject.org/cgit/cgit.cgi/poky- > > contrib/log/?h=lerner/trim_v arpath_7414> > > > > is good to go, then. I've opened this > > > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=7463 > > > > for the configuration file paths. > > > > Cheers > > > > Belén > > > > > > > > > > > >Dave > > > > > >> > > >> Thanks! > > >> > > >> Belén > > >> > > >> On 12/03/2015 15:48, "Lerner, Dave" <[email protected]> > wrote: > > >> > > >> >rebased. > > >> >Dave > > >> > > > >> >> -----Original Message----- > > >> >> From: Lerner, Dave > > >> >> Sent: Thursday, March 12, 2015 10:46 AM > > >> >> To: Barros Pena, Belen ([email protected]) > > >> >> Subject: RE: [review-request] 7414-cut the prefix from layer > file > > >>paths > > >> >>for bitbake > > >> >> variables > > >> >> > > >> >> I don't think that I rebased (since Tuesday) before I > pushed. Can > > >>you > > >> >>hold off pulling > > >> >> for 15 minutes? I'll send a note when rebased. > > >> >> Dave > > >> >> > > >> >> > -----Original Message----- > > >> >> > From: Lerner, Dave > > >> >> > Sent: Thursday, March 12, 2015 10:29 AM > > >> >> > To: Barros Pena, Belen ([email protected]); > Damian, > > >> >>Alexandru > > >> >> > ([email protected]) > > >> >> > Cc: [email protected] > > >> >> > Subject: [review-request] 7414-cut the prefix from layer > file paths > > >> >>for bitbake > > >> >> > variables > > >> >> > > > >> >> > > > >> > > >>>> > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/tr > > >>>>im > > >> >>_varpath_7414 > > >> >> > > > >> >> > > > >> >> > Page Testing: > > >> >> > Create project using yocto master which includes > openembedded-core, > > >> >>meta-yocto and > > >> >> meta- > > >> >> > yocto-bsp, then add layers meta-oe, meta-games. > > >> >> > Build the project. > > >> >> > > > >> >> > Open the build, configuration page, bitbake variables. > > >> >> > Note the following types of variable path names in the > "Set in > > >>file" > > >> >>column and when > > >> >> > clicking the variable in the History. > > >> >> > > > >> >> > Variable: B > > >> >> > Set in file/history: meta/conf/bitbake.conf > > >> >> > > > >> >> > Variable: BBFILE_PATTERN_core > > >> >> > Set in file: full path to configure > > >> >> > History: first meta/conf/layer.conf, then > > >> >> > > /path/_poky_master.toaster_cloned/bitbake/lib/bb/data_smart.py > > >> >> > > > >> >> > Variable: BBFILE_PATTTERN_games-layers > > >> >> > Set in file and History: > > >> >>meta-games_master.toaster_cloned/conf/layer.conf > > >> >> > > > >> >> > > > >> >> > HTML Validation: Pass > > >> >> > Dave Lerner > > >> > > > > > > > -- > > _______________________________________________ > > toaster mailing list > > [email protected] > > https://lists.yoctoproject.org/listinfo/toaster > > > > > > > > > > > > -- > > > > Alex Damian > > Yocto Project > > > > SSG / OTC > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
