Hi,
OK, Pushed with those changes to the branch with the same name.
Thanks,
Michael
On 15/05/15 14:58, Damian, Alexandru wrote:
Hi,
Good work ! I like the approach to change hardcoded values with
environment variables.
I would suggest that the variables have relevant names, e.g. prefixed
with "TTS_" for Toaster Testing System. Also, we need big fat warnings
if the variables are not set - this will help other people run the tests.
I would prefer to have the patch split into changes for the tests
themselves, and changes to the toaster to fix failing tests.
Cheers,
Alex
On Thu, May 14, 2015 at 4:41 PM, Michael Wood
<[email protected] <mailto:[email protected]>> wrote:
Special attention for review:
diff --git
a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
index 1bd5143..f0fe28e 100644
--- a/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
+++ b/bitbake/lib/toaster/bldcontrol/localhostbecontroller.py
@@ -117,7 +117,7 @@ class
LocalhostBEController(BuildEnvironmentController):
f.seek(0, 2) # jump to the end
toaster_ui_log_filelength = f.tell()
- cmd = "bash -c \"source %s/oe-init-build-env %s 2>&1
>toaster_server.log && bitbake --read conf/toaster-pre.conf
--postread conf/toaster.conf --server-only -t xmlrpc -B 0.0.0.0:0
<http://0.0.0.0:0> 2>&1 >toaster_server.log && DATABASE_URL=%s
BBSERVER=0.0.0.0:-1 daemon -d -i -D %s -o toaster_ui.log -- %s
--observe-only -u toasterui &\"" % (self.pokydirname,
self.be.builddir,
+ cmd = "bash -c \"source %s/oe-init-build-env %s 2>&1
>toaster_server.log && bitbake --read %s/conf/toaster-pre.conf
--postread %s/conf/toaster.conf --server-only -t xmlrpc -B
0.0.0.0:0 <http://0.0.0.0:0> 2>&1 >toaster_server.log &&
DATABASE_URL=%s BBSERVER=0.0.0.0:-1 daemon -d -i -D %s -o
toaster_ui.log -- %s --observe-only -u toasterui &\"" %
(self.pokydirname, self.be.builddir, self.be.builddir,
self.be.builddir,
commit 0d9e2362821ecf42f690afc0a247fd228cbbd853
Author: Michael Wood <[email protected]
<mailto:[email protected]>>
Date: Thu May 14 11:20:46 2015 +0100
bitbake: toaster: Fix all the toaster unit test cases
This fixes all the test cases that were broken and removes
some of the
hard coded values that hindered the tests being run elsewhere.
Signed-off-by: Michael Wood <[email protected]
<mailto:[email protected]>>
--
_______________________________________________
toaster mailing list
[email protected] <mailto:[email protected]>
https://lists.yoctoproject.org/listinfo/toaster
--
Alex Damian
Yocto Project
SSG / OTC
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster
