Taken for submission, Alex
On Wed, Jul 15, 2015 at 1:37 PM, Damian, Alexandru < [email protected]> wrote: > Seems fine to me. > > > On Tue, Jul 14, 2015 at 5:55 PM, Michael Wood <[email protected]> > wrote: > >> >> poky-contrib branch: michaelw/toastertable/sorting-cache-hit >> >> commit 548636b2c9a7be82bc098596c4e08ab156863e5b >> Author: Michael Wood <[email protected]> >> Date: Tue Jul 14 17:42:56 2015 +0100 >> >> bitbake: toastergui: Toastertables don't replace dash in cache key >> >> The dash character was being stripped from the cache key when we >> sanitise >> it for the memcache backend. This meant that we were getting a false >> hit >> on the cache and returning non descending results which are indicated >> by >> the dash prefix on the field name. >> >> Signed-off-by: Michael Wood <[email protected]> >> >> diff --git a/bitbake/lib/toaster/toastergui/widgets.py >> b/bitbake/lib/toaster/toastergui/widgets.py >> index 5f6b47b..0885402 100644 >> --- a/bitbake/lib/toaster/toastergui/widgets.py >> +++ b/bitbake/lib/toaster/toastergui/widgets.py >> @@ -252,8 +252,8 @@ class ToasterTable(TemplateView): >> for key, val in kwargs.iteritems(): >> cache_name = cache_name + str(key) + str(val) >> >> - # No special chars allowed in the cache name >> - cache_name = re.sub(r'[^A-Za-z0-9]', "", cache_name) >> + # No special chars allowed in the cache name apart from dash >> + cache_name = re.sub(r'[^A-Za-z0-9-]', "", cache_name) >> data = cache.get(cache_name) >> >> if data: >> >> -- >> _______________________________________________ >> toaster mailing list >> [email protected] >> https://lists.yoctoproject.org/listinfo/toaster >> > > > > -- > Alex Damian > Yocto Project > SSG / OTC > -- Alex Damian Yocto Project SSG / OTC
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
