On 04/08/2015 16:10, "[email protected] on behalf of Michael Wood" <[email protected] on behalf of [email protected]> wrote:
>Thanks submitted to bitbake (with white space fix on bitbake: >toastergui: spacing and top nav style change) oops: sorry about that. Belén > >On 04/08/15 10:48, Barros Pena, Belen wrote: >> Thanks for the review: all changes made. Same branch: >> >> bbarrosp/nav-project-changes >> >> bitbake: toastergui: add action to empty "most built" recipes >> 79ce966108ecea344e29a5ccece8f7a09f23d047 >> >> bitbake: toastergui: fix spacing in the import layers page >> f5d3d554d20eaaa36e4a9e4e281567f82ed66c17 >> >> >> bitbake: toastergui: remove project name from layer change notification >> c3606313e53c7614a09a065b9f4463363053d62a >> >> >> bitbake: toastergui: change link styles in alert-info >> acfc0dfda16bf9edcefb2dfefaea2f44cc7e635d >> >> >> bitbake: toastergui: breadcrumb fixes >> 6dd1d2325ffb70754a1b4cd5b7006176d148ba85 >> >> >> >> bitbake: toastergui: spacing and top nav style change >> 03d81dd9114073037207a30a9cb896ad06e50f95 >> >> Cheers >> >> Belén >> >> >> >> >> On 03/08/2015 17:58, "Michael Wood" <[email protected]> wrote: >> >>> On 03/08/15 11:23, Barros Pena, Belen wrote: >>>> Some tiny tweaks to the project pages after Michael's sweeping >>>>changes. >>>> >>>> >>>> >>>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarro >>>>sp >>>> /n >>>> av-project-changes >>>> >>>> bitbake: toastergui: spacing and top nav style change >>>> >>>> 03d81dd9114073037207a30a9cb896ad06e50f95 >>>> >>>> >>>> bitbake: toastergui: breadcrumb fixes >>>> >>>> 6dd1d2325ffb70754a1b4cd5b7006176d148ba85 >>> To improve this code further you can use single quotes instead of >>>having >>> to escape the double quotes. >>> >>> e.g. >>> >>> .append('<span class="divider">→</span>'); >>> >>>> bitbake: toastergui: change link styles in alert-info >>>> >>>> acfc0dfda16bf9edcefb2dfefaea2f44cc7e635d >>>> >>>> bitbake: toastergui: remove project name from layer change >>>>notification >>>> >>>> c3606313e53c7614a09a065b9f4463363053d62a >>> If we don't need the project name and link can you also remove where >>>the >>> project name and link are set i.e. these two lines: >>> >>> >>>alertMsg.children("#project-affected-name").text(libtoaster.ctx.projectN >>>am >>> e); >>> alertMsg.children("#project-affected-name").attr("href", >>> libtoaster.ctx.projectPageUrl); >>> >>> >>> >>>> bitbake: toastergui: fix spacing in the import layers page >>>> >>>> f5d3d554d20eaaa36e4a9e4e281567f82ed66c17 >>>> >>>> bitbake: toastergui: add action to empty "most built" recipes >>>> >>>> 79ce966108ecea344e29a5ccece8f7a09f23d047 >>>> >>>> Thanks! >>>> >>>> Belén >>> Everything else looks fine, Thanks! >>> >>> >>> Michael > >-- >_______________________________________________ >toaster mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/toaster -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
