Hi Belén, Thank you for the observation.
I have updated "dreyna/project_fstypes_8126" to address that issue, and the code now always pre-initializes the warning message element so that the previous value is not dangling. - David > -----Original Message----- > From: Barros Pena, Belen [mailto:[email protected]] > Sent: Wednesday, September 02, 2015 2:16 AM > To: Reyna, David > Cc: [email protected] > Subject: Re: [Toaster] [review-request][PATCH] 8126 Messages are missing > when "IMAGE_FSTYPES" field is not properly edited > > > > On 02/09/2015 08:44, "Reyna, David" <[email protected]> wrote: > > >Hi Belén, > > > >Please find the patch for 8126 here: > > > > dreyna/project_fstypes_8126 > > Hi David, > > This is looking fairly good. I've only run across one problem. This is how > to reproduce: > > 1. Click the 'change' icon for IMAGE_FSTYPES > > 2. Deselect all values: the 'save' button becomes disabled and the message > asking you to select at least one image type appears. This is the expected > behaviour > > 3. Now, click the 'cancel' link. The IMAGE_FSTYPES value stays the way it > was before you clicked the 'change' icon. This is once more the correct > behaviour > > 4. Now click the 'change' icon again. There are image types selected, but > the message 'You must select at least one image type' still shows, and the > 'Save' button is disabled. This is not the correct behaviour. As long as > there is at least one checkbox ticked you should see no message and the > 'save' button should be enabled. If you make a change (untick a box), the > validation kicks in and things return to the correct state. Sounds like we > need to check the selected values whenever the 'change' icon is clicked > > Thanks! > > Belén > > > > >Note: for the message 'label' the I insert and then show when there are > >no matches, it is guaranteed not to pollute the database because it can > >never be in the checked state. > > > >- David > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
