On 23/09/2015 15:59, "Reyna, David" <[email protected]> wrote:
>Hi Elliot, > >I can certainly do the things you describe, but it means branching >"mrb_section.html" or addition conditionals therein, which I was hoping >to avoid at this > date. In my opinion, this might be worth doing. Text might seem a small thing, but it does help people know where they are and not get lost. If we use conditionals to show the right text or we create a separate template I am not too fuzzy about, but it would be nice to get the right headings in place. Thanks!! Belén > >- David > >From: Smith, Elliot [mailto:[email protected]] > >Sent: Wednesday, September 23, 2015 7:45 AM >To: Reyna, David >Cc: BARROS PENA, BELEN; [email protected] >Subject: Re: [Toaster] [review-request][PATCH] 8186 - The Builds tab in >the project page is missing the 'Latest project builds' > > > >Hello David. > >On 23 September 2015 at 11:02, Reyna, David <[email protected]> >wrote: >I have posted a patch for 8186: > dreyna/project_mrb_8186 > > >I've had a look at this branch, and it seems to be working well. > > > >However, the styling doesn't quite seem to match the design Belen >provided (https://bugzilla.yoctoproject.org/attachment.cgi?id=2669). > > > >* The "Latest builds" heading should be in a smaller font without an >underline, to match the "Project builds" heading. > > > >* "Latest builds" should probably read "Latest project builds" to more >easily differentiate these builds from those shown on the all builds page. > > > >* In the design, the heading is "All project builds" rather than "Project >builds", to contrast with "Latest project builds". > > > >I'm not sure how important these details are (I don't know how closely we >try to stick to designs), but I thought I'd mention them anyway. > > > >On a different point, it would be great if we could include tests for >view code like this. It should be fairly easy to test that the correct >builds are shown for a project under the different circumstances you >described. See toastergui/tests.py > for some examples. (Of course, tests aren't mandatory.) > > > >Cheers, > >Elliot > > > > > > > > > > > * I have tested it against two different projects that have unique >builds, and I only see those most recent builds for the respective >projects. > > * When I select a project without builds, I see "Latest builds" with >nothing listed as expected, and with no crashing. > > * I was able to easily reuse "_get_latest_builds(prj)" with the project >parameter in the view, and insert "mrb_section.html" for the template. > >- David > >-- >_______________________________________________ >toaster mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/toaster > > > > > > > > >-- >Elliot Smith >Software Engineer >Intel Open Source Technology Centre > > > > > > > -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
