Hi, I'm confused as it looks to me like ed's 8004 patch is behaving as you outlined above; To reproduce: 1) new proj off master 2) goto layers 3) search meta-shr 4) it shows 4 dependencies in the table which is the number of 1st level deps it has (see http://layers.openembedded.org/layerindex/branch/master/layer/meta-shr/ ) 5) click add for meta-shr. the dialog box pops up with the 4 missing dependencies. Note, the dialog box does not have openembedded-core which is already in the project and it adds the 2nd level dependency for meta-systemd. 6) once meta-shr has been added there are a total of 8 layers in the proj. 7) the meta-shr layer details page show 4 (1st level) deps which match the ones in the compatible layers table.
This seems correct to me, am I missing something? -b On Thu, Oct 1, 2015 at 8:51 AM, Barros Pena, Belen <[email protected]> wrote: > > > On 01/10/2015 14:56, "[email protected] on behalf of Ed > Bartosh" <[email protected] on behalf of > [email protected]> wrote: > >>Hi, >> >>This patchset fixes bug 8004: importing a layer from the recipes page >>auto adds the 1st level dependencies but not the 2nd level. >>Now dependent layers are discovered recursively and Toaster shows all of >>them >>in Compatible layers view when user clicks 'Add layer' button. >> >>The patchset includes fixes for orm test suite and new test case for >>Layer_Version.get_alldeps API used in this bug fix. >> >>Changes in v2: UI shows number of first level deps in compatible layers >>page. >> (Reverted two patches from v1) >> >>The following changes since commit >>7b10ae122d46891c734e786358ea5f36760e8d5e: > > I am bit confused. Now the number of dependencies shown in the 'compatible > layers' table matches the dependencies shown in the modal dialog. But I > don't think this is the correct behaviour: the information in the table > should match the information in the layer details page. Those 2 places > (the table and the layer details page) show the 'objective' information > about the layer. The modal dialog, on the other hand, takes into account > the state of the project configuration, and shows you which layers you > still need to add in order to satisfy the layer dependencies. > > So both the 'compatible layers' table and the layer details page should > show the fist-level dependencies for a layer. Sorry if I wasn't clear > before :/ > > Thanks! > > Belén > >> >> toaster: Fix broken test case (2015-10-01 10:42:16 +0100) >> >>are available in the git repository at: >> >> git://git.yoctoproject.org/poky-contrib ed/toaster/8004 >> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/8004 >> >>Ed Bartosh (5): >> toaster: implement API to get full list of deps >> toaster: use get_alldeps in layerdetails renderer >> toaster: fix NameError >> toaster: fix orm tests >> toaster: test get_alldeps API >> >> bitbake/lib/toaster/orm/models.py | 21 ++++++++++++- >> bitbake/lib/toaster/orm/tests.py | 53 >>++++++++++++++------------------- >> bitbake/lib/toaster/toastergui/views.py | 4 +-- >> 3 files changed, 45 insertions(+), 33 deletions(-) >> >>-- >>Regards, >>Ed >> >>-- >>_______________________________________________ >>toaster mailing list >>[email protected] >>https://lists.yoctoproject.org/listinfo/toaster > > -- > _______________________________________________ > toaster mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/toaster -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
