On 6 October 2015 at 12:23, Belen Barros Pena < [email protected]> wrote:
> YOCTO #8131 records that the sorting by 'errors', 'warnigns' > and 'time', and the filtering by 'errors' and 'warnings' > are broken in the 'all builds' and 'project builds' pages. > > To avoid exposing broken functionality to users, comment > out the sorting and filtering in those columns until we > we have a fix for YOCTO #8131. > > Signed-off-by: Belen Barros Pena <[email protected]> > Looks good to me, and GUI tests pass (NB orm tests are broken, pending Ed's patch), so sent upstream to bitbake-devel. Elliot > --- > bitbake/lib/toaster/toastergui/views.py | 49 > +++++++++++++++++---------------- > 1 file changed, 26 insertions(+), 23 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/views.py > b/bitbake/lib/toaster/toastergui/views.py > index 9f16e8f..db791cf 100755 > --- a/bitbake/lib/toaster/toastergui/views.py > +++ b/bitbake/lib/toaster/toastergui/views.py > @@ -2103,35 +2103,38 @@ if True: > }, > {'name': 'Errors', 'clclass': 'errors_no', > 'qhelp': "How many errors were encountered during > the build (if any)", > - 'orderfield': _get_toggle_order(request, > "errors_no", True), > - 'ordericon':_get_toggle_order_icon(request, > "errors_no"), > - 'orderkey' : 'errors_no', > - 'filter' : {'class' : 'errors_no', > - 'label': 'Show:', > - 'options' : [ > - ('Builds with errors', > 'errors_no__gte:1', queryset_with_search.filter(errors_no__gte=1).count()), > - ('Builds without errors', > 'errors_no:0', queryset_with_search.filter(errors_no=0).count()), > - ] > - } > + # Comment out sorting and filter until YOCTO #8131 > is fixed > + #'orderfield': _get_toggle_order(request, > "errors_no", True), > + #'ordericon':_get_toggle_order_icon(request, > "errors_no"), > + #'orderkey' : 'errors_no', > + #'filter' : {'class' : 'errors_no', > + # 'label': 'Show:', > + # 'options' : [ > + # ('Builds with errors', > 'errors_no__gte:1', queryset_with_search.filter(errors_no__gte=1).count()), > + # ('Builds without errors', > 'errors_no:0', queryset_with_search.filter(errors_no=0).count()), > + # ] > + # } > }, > {'name': 'Warnings', 'clclass': 'warnings_no', > 'qhelp': "How many warnings were encountered during > the build (if any)", > - 'orderfield': _get_toggle_order(request, > "warnings_no", True), > - 'ordericon':_get_toggle_order_icon(request, > "warnings_no"), > - 'orderkey' : 'warnings_no', > - 'filter' : {'class' : 'warnings_no', > - 'label': 'Show:', > - 'options' : [ > - ('Builds with > warnings','warnings_no__gte:1', > queryset_with_search.filter(warnings_no__gte=1).count()), > - ('Builds without > warnings','warnings_no:0', > queryset_with_search.filter(warnings_no=0).count()), > - ] > - } > + # Comment out sorting and filter until YOCTO #8131 > is fixed > + #'orderfield': _get_toggle_order(request, > "warnings_no", True), > + #'ordericon':_get_toggle_order_icon(request, > "warnings_no"), > + #'orderkey' : 'warnings_no', > + #'filter' : {'class' : 'warnings_no', > + # 'label': 'Show:', > + # 'options' : [ > + # ('Builds with > warnings','warnings_no__gte:1', > queryset_with_search.filter(warnings_no__gte=1).count()), > + # ('Builds without > warnings','warnings_no:0', > queryset_with_search.filter(warnings_no=0).count()), > + # ] > + # } > }, > {'name': 'Time', 'clclass': 'time', 'hidden' : 1, > 'qhelp': "How long it took the build to finish", > - 'orderfield': _get_toggle_order(request, > "timespent", True), > - 'ordericon':_get_toggle_order_icon(request, > "timespent"), > - 'orderkey' : 'timespent', > + # Comment out sorting until YOCTO #8131 is fixed > + #'orderfield': _get_toggle_order(request, > "timespent", True), > + #'ordericon':_get_toggle_order_icon(request, > "timespent"), > + #'orderkey' : 'timespent', > }, > {'name': 'Image files', 'clclass': 'output', > 'qhelp': "The root file system types produced by the > build. You can find them in your <code>/build/tmp/deploy/images/</code> > directory", > -- > 2.3.8 (Apple Git-58) > > -- > _______________________________________________ > toaster mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/toaster > -- Elliot Smith Software Engineer Intel Open Source Technology Centre
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
