Submitted upstream. On Tue, Oct 06, 2015 at 12:21:09PM +0100, Elliot Smith wrote: > This implements changes across the UI to hide irrelevant options > for command-line builds, and show additional help icons explaining > why those options are hidden. > > It also modifies the behaviour of the "New build" button to take > account of the special status of the command-line builds project. > > For UI details, see the document attached to bug 8231 > at https://bugzilla.yoctoproject.org/attachment.cgi?id=2760. > > v2 (in response to Belen's review): > > * Modify how the form for changing the project name is shown, so > that the edit buttons aren't lost after saving the new project name. > Also verify that project name changes take without requiring a page refresh. > > * Never select the command-line builds project in the "New build" > drop-down form. > > * Only show the "New build" button if there are one or more user-created > projects (i.e. not if there is only the command-line builds project). > > v1: > > * One of the changes in the design document has not been implemented: > it's not possible to hide the "customise image recipe" links and > buttons (page 9) as these are not in the templates yet. > > * The visual design differs slightly from the design document, as it > incorporates a new layout for the build dashboard which is not > implemented yet. > > * The "New build" button is displayed on the command line > builds project page, as we came to the conclusion that the logic > in the JavaScript (i.e. show the new build button if there is no > build input form on the page) should apply in the case of the > builds page for the "command line builds" project. > > Changes since 66ab34a41658e2f275a83853bb19cf49bf7cc74d (toaster-next) are in > git://git.yoctoproject.org/poky-contrib, elliot/toaster/cli_builds_ui-8231 > http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/cli_builds_ui-8231 > > Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8231 > > Elliot Smith (10): > toaster: Reorganise and lint tests > toaster: Replace "Run again" button with help text for cli builds > toaster: Show 'not applicable' for default project machine and release > toaster: Make the builds view the project page for "command line > builds" > toaster: Hide tabs and add info popups for command line builds > toaster: Show tooltip next to cli builds project name in all builds > toaster: More linting of tests > toaster: Clean up template code > toaster: Exclude "command line builds" project from projects typeahead > toaster: Modify "New build" button behaviour for cli builds project > > .../lib/toaster/toastergui/static/css/default.css | 5 + > bitbake/lib/toaster/toastergui/static/js/base.js | 18 +- > bitbake/lib/toaster/toastergui/templates/base.html | 98 ++++--- > .../lib/toaster/toastergui/templates/builds.html | 19 +- > .../toaster/toastergui/templates/mrb_section.html | 66 +++-- > .../lib/toaster/toastergui/templates/projects.html | 23 +- > .../toastergui/templates/projecttopbar.html | 80 ++--- > .../toastergui/templatetags/project_url_tag.py | 34 +++ > bitbake/lib/toaster/toastergui/tests.py | 322 > ++++++++++++++++++--- > bitbake/lib/toaster/toastergui/typeaheads.py | 4 +- > bitbake/lib/toaster/toastergui/views.py | 9 +- > 11 files changed, 494 insertions(+), 184 deletions(-) > create mode 100644 > bitbake/lib/toaster/toastergui/templatetags/project_url_tag.py > > -- > Elliot Smith > Software Engineer > Intel OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > -- > _______________________________________________ > toaster mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/toaster
-- -- Regards, Ed -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
