On Wed, Oct 14, 2015 at 05:55:46PM -0700, Brian Avery wrote: > Also, > > Michael mentioned that he didn't have realpath installed (on ubuntu it > is a separate dpkg). This patch will check for realpath and if it > doesn't find it, it will look for readlink (readlink -f will > accomplish the same thing as realpath) and if it doesn't find that it > will complain and exit. > -b >
Thank you for review and testing! Fixed both issues and updated ed/toaster/fixes-for-toaster-script please review and submit > > On Wed, Oct 14, 2015 at 4:55 PM, Brian Avery <[email protected]> wrote: > > The source of the problem is that you switched from the meta-yocto > > toasterconf to the meta toasterconf as the default. The > > meta/conf/toasterconf.json is only for pure open embedded (non poky) > > runs. It shouldn't be the default as it can't build anything unless > > you add some layers by hand. > > > > - export TOASTER_CONF="$BIN_DIR/../../meta-yocto/conf/toasterconf.json" > > > > + TOASTER_CONF="$(dirname $TOASTER)/../../meta/conf/toasterconf.json" > > > > On the assumption that this was a typo, I amended your git 8d7023f41 > > to be meta-yocto and signed off on it. I also signed off on the other > > 3 commits. > > > > If you agree that this amend makes sense, go ahead and upstream it and > > add it to toaster-next. It already has 2 signoffs on it so it's good > > to go. > > > > the branch with the 2 signoffs is on > > bavery/submit/ed/2015-10-14_fix-script-for-2-modes on poky-contrib. > > > > -b > > > > On Wed, Oct 14, 2015 at 1:00 PM, Brian Avery <[email protected]> wrote: > >> Tried it but had an issue. > >> To replicate issue > >> be in a directory that is *not* poky > >>> ~/src/poky/bitbake/bin/toaster > >> then make a new project. > >> you will see that it does not have enough layers. (missing meta and > >> meta-yocto) > >> building bash then fails with > >> ShellCmdException: command: git clone "" > >> "/home/bavery/src/intel/yocto-builds/TOASTER/myBugs2/elliot-cli-8231/managed/_toaster_clones/__master" > >> > >> fatal: repository '' does not exist > >> > >> > >> Note, if this is done from the poky directory, it works, but it needs > >> to work from a build dir as well so people do not *have* to dirty up > >> their src dir. > >> -b > >> > >> On Wed, Oct 14, 2015 at 6:10 AM, Barros Pena, Belen > >> <[email protected]> wrote: > >>> > >>> > >>> On 14/10/2015 13:33, "[email protected] on behalf of Ed > >>> Bartosh" <[email protected] on behalf of > >>> [email protected]> wrote: > >>> > >>>>Hi, > >>>> > >>>>This patchset should make toaster script working in both modes. > >>>>It was not possible due to the way TOASTER_CONF variable was set. > >>>> > >>>>The following changes since commit > >>>>c1ba977bf55424bf9f9e899db89eafa338edccb4: > >>>> > >>>> toaster: importlayer Update property names for importlayer api calls > >>>>(2015-10-14 14:11:23 +0300) > >>>> > >>>>are available in the git repository at: > >>>> > >>>> git://git.yoctoproject.org/poky-contrib > >>>>ed/toaster/fixes-for-toaster-script > >>>> > >>>>http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/fixes- > >>>>for-toaster-script > >>> > >>> Pending code review, this works for me. I can start toaster in 'build' > >>> mode the usual way (bitbake/bin/toaster) and I can start toaster in > >>> 'analysis' mode by sourcing the build environment script, then sourcing > >>> the toaster script (. ../bitbake/bin/toaster). > >>> > >>> Both modes build for me, and cli builds are picked up by Toaster. > >>> > >>> Cheers > >>> > >>> Belén > >>> > >>>> > >>>>Ed Bartosh (4): > >>>> toaster: use path to the script to guess config path > >>>> toaster: get rid of SRCFILE > >>>> toaster: set TOASTER_MANAGED variable > >>>> toaster: exit or return depending on the mode > >>>> > >>>> bitbake/bin/toaster | 16 +++++++--------- > >>>> 1 file changed, 7 insertions(+), 9 deletions(-) > >>>> > >>>>-- > >>>>2.1.4 > >>>> > >>>>-- > >>>>_______________________________________________ > >>>>toaster mailing list > >>>>[email protected] > >>>>https://lists.yoctoproject.org/listinfo/toaster > >>> > >>> -- > >>> _______________________________________________ > >>> toaster mailing list > >>> [email protected] > >>> https://lists.yoctoproject.org/listinfo/toaster -- -- Regards, Ed -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
