On 10/11/15 14:51, Belen Barros Pena wrote:
From: Belen Barros Pena <[email protected]>
The 'all builds' page was missing the download icon
next to the outcome icon, which allows you to download
a build log from the 'all builds' page.
This patch brings it back.
Signed-off-by: Belen Barros Pena <[email protected]>
---
bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html
b/bitbake/lib/toaster/toastergui/templates/builds.html
index a27a121..9f07211 100644
--- a/bitbake/lib/toaster/toastergui/templates/builds.html
+++ b/bitbake/lib/toaster/toastergui/templates/builds.html
@@ -62,7 +62,13 @@
{% for build in objects %}
<tr class="data" data-table-build-result="{{ build.id }}">
<td class="outcome">
- <a href="{% url "builddashboard" build.id %}">{%if build.outcome == build.SUCCEEDED%}<i class="icon-ok-sign
success"></i>{%elif build.outcome == build.FAILED%}<i class="icon-minus-sign error"></i>{%else%}{%endif%}</a>
+ <a href="{% url "builddashboard" build.id %}">{%if build.outcome == build.SUCCEEDED%}<i
class="icon-ok-sign success"></i>{%elif build.outcome == build.FAILED%}<i class="icon-minus-sign
error"></i>{%else%}{%endif%}</a>
+ {% if build.project %}
+
+ <a href="{% url 'build_artifact' build.id "cookerlog" build.id
%}">
+ <i class="icon-download-alt" title="" data-original-title="Download
build log"></i>
+ </a>
+ {% endif %}
</td>
<td class="target">
{% for t in build.target_set.all %}
Could you format the template logic on that first line so that there is
indentation in the logic sequence, for ease of reading. To avoid an
empty else statement it's better to switch round the logic to be inclusive.
Something more like
{% if build.outcome == build.SUCCEEDED or build.outcome == build.FAILED
%} <a href="{% url "builddashboard" build.id %}"> <i class=" {% if
build.outcome == build.SUCCEEDED %} icon-ok-sign success {% elif
build.outcome == build.FAILED %} icon-minus-sign error {% endif %}
"></i> </a> {% endif %}
more info on
https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Templates
Thanks
Michael
--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster
