On 27 November 2015 at 12:09, Mihail, StanciuX <[email protected]> wrote:
> I’ve rebased my patch: > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=mstanciu/toaster-ui-tests-fix&id=66da2599adaa469ba6f6737a2600a00363b07ee0 Apologies, Mihai: I was getting the conflict because your branch actually has two commits, though you only referred to one of them in your review request. I ran the full test suite (the list of tests for Mac) on Linux, some of which failed (just for your reference). I'll let you decide what to do about that. Anyway, I will merge the patches. Though I should reiterate: I would really like some instructions to be added to the toasteruitest/ directory. There are no instructions on how to run the tests, which made it a bit difficult for me to check your changes. A short README would be acceptable. Thanks. Elliot > > > Regards, > Mihai > > From: Smith, Elliot [mailto:[email protected]] > Sent: Thursday, November 26, 2015 7:01 PM > To: Mihail, StanciuX > Cc: [email protected] > Subject: Re: [Toaster] [review request] Update UI tests to work with 2.0 > changes > > Hell Mihail. > > On 25 November 2015 at 10:02, Mihail, StanciuX <[email protected] > <mailto:[email protected]>> wrote: > Changes can be found here: > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=mstanciu/toaster-ui-tests-fix&id=7296d1c7367e62a5e72fcbae8dd4b5c00c2bc7f4 > > This doesn't merge cleanly with toaster-next (it clashes on > bitbake/lib/toaster/contrib/tts/toasteruitest/toaster_automation_test.py). > > Could you please rebase and fix the conflicts, then I'll test again. > > Thanks. > Elliot > > > Feedback would be appreciated. > > Cheers, > Mihai > > -- > _______________________________________________ > toaster mailing list > [email protected]<mailto:[email protected]> > https://lists.yoctoproject.org/listinfo/toaster > > > > -- > Elliot Smith > Software Engineer > Intel Open Source Technology Centre > -- Elliot Smith Software Engineer Intel Open Source Technology Centre
-- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
