Rename the recipe_id to custrecipeid to avoid confusion about which type of object we're going to be accessing. This means that in the unit tests for tables we can pass a different kwargs for custom recipes vs normal recipes.
Signed-off-by: Michael Wood <[email protected]> --- bitbake/lib/toaster/toastergui/tables.py | 12 ++++++++---- bitbake/lib/toaster/toastergui/urls.py | 4 ++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/bitbake/lib/toaster/toastergui/tables.py b/bitbake/lib/toaster/toastergui/tables.py index 9476887..2b3684b 100644 --- a/bitbake/lib/toaster/toastergui/tables.py +++ b/bitbake/lib/toaster/toastergui/tables.py @@ -685,7 +685,8 @@ class SelectPackagesTable(PackagesTable): self.title = "Add | Remove packages" def setup_queryset(self, *args, **kwargs): - cust_recipe = CustomImageRecipe.objects.get(pk=kwargs['recipeid']) + self.cust_recipe =\ + CustomImageRecipe.objects.get(pk=kwargs['custrecipeid']) prj = Project.objects.get(pk = kwargs['pid']) current_packages = self.cust_recipe.get_all_packages() @@ -705,13 +706,16 @@ class SelectPackagesTable(PackagesTable): self.queryset = self.queryset.order_by('name') - self.static_context_extra['recipe_id'] = kwargs['recipeid'] + self.static_context_extra['recipe_id'] = kwargs['custrecipeid'] self.static_context_extra['current_packages'] = \ - cust_recipe.packages.values_list('pk', flat=True) + current_packages.values_list('pk', flat=True) def get_context_data(self, **kwargs): + # to reuse the Super class map the custrecipeid to the recipe_id + kwargs['recipe_id'] = kwargs['custrecipeid'] context = super(SelectPackagesTable, self).get_context_data(**kwargs) - custom_recipe = CustomImageRecipe.objects.get(pk=kwargs['recipe_id']) + custom_recipe = \ + CustomImageRecipe.objects.get(pk=kwargs['custrecipeid']) context['recipe'] = custom_recipe context['approx_pkg_size'] = \ diff --git a/bitbake/lib/toaster/toastergui/urls.py b/bitbake/lib/toaster/toastergui/urls.py index 36e5c38..57baa4d 100644 --- a/bitbake/lib/toaster/toastergui/urls.py +++ b/bitbake/lib/toaster/toastergui/urls.py @@ -123,11 +123,11 @@ urlpatterns = patterns('toastergui.views', name=tables.LayerMachinesTable.__name__.lower()), - url(r'^project/(?P<pid>\d+)/customrecipe/(?P<recipeid>\d+)/selectpackages/$', + url(r'^project/(?P<pid>\d+)/customrecipe/(?P<custrecipeid>\d+)/selectpackages/$', tables.SelectPackagesTable.as_view(), name="recipeselectpackages"), - url(r'^project/(?P<pid>\d+)/customrecipe/(?P<recipe_id>\d+)$', + url(r'^project/(?P<pid>\d+)/customrecipe/(?P<custrecipeid>\d+)$', tables.SelectPackagesTable.as_view(template_name="customrecipe.html"), name="customrecipe"), -- 2.1.4 -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
