I applied the buildstats series on top of toaster-next, ran a build, and
checked the build stats info. I can see time per task coming in. I cannot
see cpu usage or disk i/o data in the UI because of this

https://bugzilla.yoctoproject.org/show_bug.cgi?id=8571

But there is data for both in the database, and it looks sane. So I guess,
from the UI standpoint, the patches are ok: things were as broken as they
were before ;)

Cheers

Belén

On 17/12/2015 14:54, "[email protected] on
behalf of Richard Purdie"
<[email protected] on behalf of
[email protected]> wrote:


>This updates the toaster class to use the new data format from buildstats.
>This does mean it will no longer read IO data from older builds, however
>since that data is completely useless anyway, I don't consider that to be
>an issue.
>
>Signed-off-by: Richard Purdie <[email protected]>
>
>diff --git a/meta/classes/toaster.bbclass b/meta/classes/toaster.bbclass
>index d63cff5..7af495e 100644
>--- a/meta/classes/toaster.bbclass
>+++ b/meta/classes/toaster.bbclass
>@@ -199,8 +199,6 @@ python toaster_collect_task_stats() {
>     def _read_stats(filename):
>         cpu_usage = 0
>         disk_io = 0
>-        startio = '0'
>-        endio = '0'
>         started = '0'
>         ended = '0'
>         pn = ''
>@@ -215,11 +213,11 @@ python toaster_collect_task_stats() {
>         if "CPU usage" in statinfo:
>             cpu_usage = str(statinfo["CPU usage"]).strip('% \n\r')
> 
>-        if "EndTimeIO" in statinfo:
>-            endio = str(statinfo["EndTimeIO"]).strip('% \n\r')
>+        if "IO write_bytes" in statinfo:
>+            disk_io = disk_io + str(statinfo["IO write_bytes"]).strip('%
>\n\r')
> 
>-        if "StartTimeIO" in statinfo:
>-            startio = str(statinfo["StartTimeIO"]).strip('% \n\r')
>+        if "IO read_bytes" in statinfo:
>+            disk_io = disk_io + str(statinfo["IO read_bytes"]).strip('%
>\n\r')
> 
>         if "Started" in statinfo:
>             started = str(statinfo["Started"]).strip('% \n\r')
>@@ -227,8 +225,6 @@ python toaster_collect_task_stats() {
>         if "Ended" in statinfo:
>             ended = str(statinfo["Ended"]).strip('% \n\r')
> 
>-        disk_io = int(endio) - int(startio)
>-
>         elapsed_time = float(ended) - float(started)
> 
>         cpu_usage = float(cpu_usage)
>
>
>-- 
>_______________________________________________
>Openembedded-core mailing list
>[email protected]
>http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to