On 18 December 2015 at 09:23, Elliot Smith <[email protected]> wrote:

> Convert some of the most important Toaster pages to ToasterTable rather
> than
> individual templates.
>

I just realised two things I missed:

1. I added a new Python file, but neglected to add the licence header.
2. I left the old (commented-out) view code in views.py.

I'll fix (1) in the branch, but I'll leave (2) until after review, in case
there's some code I need to port and have missed.

Elliot


>
> This involved a rewrite of the ToasterTable filter system (see
> tablefilter.py)
> to cope with date range filtering for the builds tables.
>
> I also moved a lot of code out of the views into the model, where it seems
> better placed.
>
> I also fixed a few JS issues which arose while testing, such as filters
> not de-selecting when there are multiple filters on a table; event handlers
> being lost when repopulating a table; and incorrect hiding of page elements
> due to table classes being used for the page title element.
>
> Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8738
>
> Also incidentally fixes
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=8792,
> as this functionality works correctly in ToasterTable.
>
> Changes since 6d35574 (toaster-next) are in
> git://git.yoctoproject.org/poky-contrib, elliot/toaster/tables-8738
>
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/tables-8738
>
> Elliot Smith (17):
>   toaster: toastergui Use ToasterTable for projects page
>   toaster: Move image file suffix list to model
>   toaster: Check inferred file suffixes against list of known types
>   toaster: toastergui Switch projects/ view to ToasterTable
>   toaster: toastergui Use event delegates for hover help elements
>   toaster: toastergui Convert all builds page to ToasterTable
>   toaster: toastergui Add QuerysetFilter class
>   toaster: toastergui Refactor ToasterTable filtering
>   toaster: toastergui Switch off filter highlights when inactive
>   toaster: toastergui Show recent builds on all builds page
>   toaster: toastergui Implement date range filters for builds
>   toaster: toastergui Implement "today" and "yesterday" filters
>   toaster: toastergui Convert project builds page to ToasterTable
>   toaster: tests Fix Django tests for new ToasterTable pages
>   toaster: toastergui Don't hide all elements with .col class
>   toaster: toastergui Ensure filter_value updates
>   toaster: toastergui Streamline construction of filter objects
>
>  bitbake/lib/toaster/orm/models.py                  | 109 ++-
>  .../lib/toaster/toastergui/static/js/libtoaster.js |   6 +-
>  .../toaster/toastergui/static/js/projecttopbar.js  |   9 +
>  bitbake/lib/toaster/toastergui/static/js/table.js  | 272 +++++--
>  bitbake/lib/toaster/toastergui/tablefilter.py      | 271 +++++++
>  bitbake/lib/toaster/toastergui/tables.py           | 826
> +++++++++++++++++++--
>  .../toastergui/templates/baseprojectpage.html      |   1 +
>  .../toastergui/templates/builds-toastertable.html  |  48 ++
>  .../toaster/toastergui/templates/mrb_section.html  |   4 +-
>  .../templates/projectbuilds-toastertable.html      |  56 ++
>  .../templates/projects-toastertable.html           |  36 +
>  .../toaster/toastergui/templates/toastertable.html |   7 +-
>  bitbake/lib/toaster/toastergui/tests.py            | 255 ++++---
>  bitbake/lib/toaster/toastergui/urls.py             |  14 +-
>  bitbake/lib/toaster/toastergui/views.py            |  79 +-
>  bitbake/lib/toaster/toastergui/widgets.py          |  94 ++-
>  16 files changed, 1781 insertions(+), 306 deletions(-)
>  create mode 100644 bitbake/lib/toaster/toastergui/tablefilter.py
>  create mode 100644
> bitbake/lib/toaster/toastergui/templates/builds-toastertable.html
>  create mode 100644
> bitbake/lib/toaster/toastergui/templates/projectbuilds-toastertable.html
>  create mode 100644
> bitbake/lib/toaster/toastergui/templates/projects-toastertable.html
>
> --
> Elliot Smith
> Software Engineer
> Intel OTC
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
>


-- 
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
-- 
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to