Hi Sujith,

Can you split your changes please?
I'd suggest to at least separate backend changes from frontend ones.

Having uihelper.py changes in a separate commit would be nice too.
It looks like you've spotted correctly that findServerDetails is not
used anywhere in bitbake code. You can remove it in a separate commit as
it looks unrelated to the rest of the patch.

+1 for Michael's suggestion to use build controller.

On Thu, Dec 17, 2015 at 10:26:11PM +0530, sujith h wrote:
> Hi,
> 
> I have posted my changes in:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toaster-build-cancel
> 
> Kindly review my changes and let me know if I have to make changes. I would
> be happy to do so.
> 
> Thanks for all helping hand from RP, Ed, Michael, Belen and Paul.
> 
> Thanks,
> Sujith H

--
Regards,
Ed
-- 
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to