Hi Belen, Thank you for review!
I've fixed the issues you've found and updated my branch ed/toaster/provides-6169 Regards, Ed On Tue, Jan 05, 2016 at 12:19:08PM +0000, Barros Pena, Belen wrote: > > > On 29/12/2015 11:56, "[email protected] on behalf of Ed > Bartosh" <[email protected] on behalf of > [email protected]> wrote: > > >Hi, > > > >This patchset adds support of PROVIDES to Toaster backend and frontend. > >Please looks at https://bugzilla.yoctoproject.org/show_bug.cgi?id=6169 to > >see more details. > > > >The following changes since commit > >f74e9383daaba1bc8eb761579f01fadc48771f4a: > > > > toaster-manual: describe the way to start Toaster (2015-12-29 12:53:04 > >+0200) > > > >are available in the git repository at: > > > > git://git.yoctoproject.org/poky-contrib ed/toaster/provides-6169 > > > >http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=ed/toaster/provid > >es-6169 > > This looks good to me. Just a couple of small presentation issues: > > * In the 'recipe details' tab, the help text for the 'PROVIDES' entry > should say > > A list of aliases by which a particular recipe can be known. The > additional aliases are synonyms for the recipe and can be useful > satisfying dependencies of other recipes during the build > > Right now it says > > List of names that this recipe privides > > > * In the dependencies tabs, only the recipe name should be inside the > anchor tag. Right now, the 'satisfied via ...' it's also inside the anchor > tag, and that creates an uncomfortable effect when you hover in order to > click the recipe name. > > * Also in the dependencies tabs, the question mark icon should only show > in the table when you hover over the cell (we do this across all tables > and keeps the tables a bit cleaner). You just need to apply the hover-help > class to the <i> tag > > That's all. Thanks! > > Belén > > > > >Ed Bartosh (8): > > taskdata: refactor get_providermap > > cooker: add providermap to dep_tree > > buildinfohelper: use providermap > > toaster: add Provider model > > buildinfohelper: add porvides info to the db > > toaster: show list of provides for the recipe > > toaster: show 'satisfied via' text for build deps > > toaster: show 'satisfied via' text for reverse deps > > > > bitbake/lib/bb/cooker.py | 7 +++++ > > bitbake/lib/bb/runqueue.py | 2 +- > > bitbake/lib/bb/taskdata.py | 17 +++++------- > > bitbake/lib/bb/ui/buildinfohelper.py | 31 > >+++++++++++++++------- > > .../orm/migrations/0002_auto_20151223_1528.py | 27 > >+++++++++++++++++++ > > bitbake/lib/toaster/orm/models.py | 5 ++++ > > .../lib/toaster/toastergui/templates/recipe.html | 25 +++++++++++++++-- > > 7 files changed, 92 insertions(+), 22 deletions(-) > > create mode 100644 > >bitbake/lib/toaster/orm/migrations/0002_auto_20151223_1528.py > > > >-- > >Regards, > >Ed > > > >-- > >_______________________________________________ > >toaster mailing list > >[email protected] > >https://lists.yoctoproject.org/listinfo/toaster > -- -- Regards, Ed -- _______________________________________________ toaster mailing list [email protected] https://lists.yoctoproject.org/listinfo/toaster
