On 11/01/2016 11:25, "[email protected] on behalf of Barros
Pena, Belen" <[email protected] on behalf of
[email protected]> wrote:

>
>
>On 09/01/2016 16:53, "sujith h" <[email protected]> wrote:
>
>>
>>I have pushed my changes to
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toas
>>t
>>er-build-cancel10
>>
>>With this change user would see the cancel button only after the actual
>>tasks start executing. So then user can click cancel button.
>>
>
>Hi Sujith,
>
>Now I can see that the 'cancel' button only appears when the build has
>started, which is great. However, when I click the button, nothing
>happens. The page seems to refresh, but I get no message telling me the
>build is being cancelled, and the build just continues.

Tested this again with a clean build directory. The 'cancel' button shows
when the build has started proper (and can therefore be cancelled). When
you click the 'cancel' button, you get the loading spinner and quite
quickly the build stops. I can then start another build without problems.

This is what the build log of the cancelled build says:

NOTE: Sending SIGTERM to remaining 40 tasks
NOTE: Logfile for task
/home/yocto/master/build/tmp/work/i586-poky-linux/libxml2/2.9.3-r0/temp/log
.do_fetch.40114
NOTE: Logfile for task
/home/yocto/master/build/tmp/work/i586-poky-linux/libxcb/1.11.1-r0/temp/log
.do_patch.40146
NOTE: Tasks Summary: Attempted 199 tasks of which 0 didn't need to be
rerun and all succeeded.
ERROR: u'core-image-minimal'
Traceback (most recent call last):
  File "/home/yocto/master/bitbake/lib/bb/ui/toasterui.py", line 357, in
main
    buildinfohelper.store_target_package_data(event)
  File "/home/yocto/master/bitbake/lib/bb/ui/buildinfohelper.py", line
1166, in store_target_package_data
    imgdata = 
BuildInfoHelper._get_data_from_event(event)['imgdata'][target.target]
KeyError: u'core-image-minimal'

ERROR: Error data dump ['  File
"/home/yocto/master/bitbake/lib/bb/ui/toasterui.py", line 357, in main\n
 buildinfohelper.store_target_package_data(event)\n']
{'_': KeyError(u'core-image-minimal',),
 'build_history_enabled': True,
 'build_log': <logging.FileHandler object at 0x7f2c4e05dcd0>,
 'build_log_file_path':
'/home/yocto/master/build/tmp/log/cooker/qemux86/build_20160111_114819.89.l
og',
 'buildinfohelper': <bb.ui.buildinfohelper.BuildInfoHelper object at
0x7f2c4e05db50>,
 'console': <logging.StreamHandler object at 0x7f2c4e05da10>,
 'consolelogfile': 
'/home/yocto/master/build/tmp/log/cooker/qemux86/20160111114813.log',
 'curr': <traceback object at 0x7f2c4e047488>,
 'debug_domains': {},
 'e': KeyError(u'core-image-minimal',),
 'errors': 0,
 'event': <bb.event.MetadataEvent object at 0x7f2c4cc36dd0>,
 'eventHandler': <bb.ui.uievent.BBUIEventQueue instance at 0x7f2c4e060bd8>,
 'exception_data': 'Traceback (most recent call last):\n  File
"/home/yocto/master/bitbake/lib/bb/ui/toasterui.py", line 357, in main\n
 buildinfohelper.store_target_package_data(event)\n  File
"/home/yocto/master/bitbake/lib/bb/ui/buildinfohelper.py", line 1166, in
store_target_package_data\n    imgdata =
BuildInfoHelper._get_data_from_event(event)[\'imgdata\'][target.target]\nKe
yError: u\'core-image-minimal\'\n',
 'first': False,
 'format_str': '%(levelname)s: %(message)s',
 'formatter': <bb.msg.BBLogFormatter object at 0x7f2c4e05da90>,
 'helper': <bb.ui.uihelper.BBUIHelper instance at 0x7f2c4e069710>,
 'inheritlist': ' poky-sanity package_rpm buildstats image-mklibs
image-prelink debian devshell sstate license blacklist sanity toaster
buildhistory',
 'interrupted': False,
 'llevel': 20,
 'log_dir': '/home/yocto/master/build/tmp/log/cooker/qemux86',
 'params': <bb.main.BitBakeConfigParameters object at 0x7f2c4f65cb50>,
 'pformat': <function pformat at 0x7f2c4ed65050>,
 'return_value': 0,
 'server': <ServerProxy for 0.0.0.0:43328/>,
 'taskfailures': [],
 'tb': <traceback object at 0x7f2c4e047488>,
 'traceback': <module 'traceback' from '/usr/lib/python2.7/traceback.pyc'>,
 'warnings': 0}

ERROR: Error data dump ['  File
"/home/yocto/master/bitbake/lib/bb/ui/buildinfohelper.py", line 1166, in
store_target_package_data\n    imgdata =
BuildInfoHelper._get_data_from_event(event)[\'imgdata\'][target.target]\n']
{'event': <bb.event.MetadataEvent object at 0x7f2c4cc36dd0>,
 'pkgdata': {},
 'self': <bb.ui.buildinfohelper.BuildInfoHelper object at 0x7f2c4e05db50>,
 'target': <Target: core-image-minimal>}

NOTE: Build exited with errorcode 0
NOTE: ToasterUI build done 1, brbe: 1:1
NOTE: ToasterUI build done 2
ERROR: Command execution failed: Forced shutdown
NOTE: Build exited with errorcode 1
NOTE: ToasterUI build done 1, brbe: 1:1
NOTE: ToasterUI build done 2

However, if I then stop Toaster and start again, the 'cancel' button no
longer works. Nothing happens when I click it: the build proceeds till the
end. 

Thanks!!

Belén




>
>Cheers
>
>Belén 
>
>>
>>I have updated comments and also updated api in orm/models.py :
>>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sujith/toas
>>t
>>er-build-cancel11
>
>-- 
>_______________________________________________
>toaster mailing list
>[email protected]
>https://lists.yoctoproject.org/listinfo/toaster

-- 
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Reply via email to